fix(convert): fix missing slides in HTML presentation after #508#515
fix(convert): fix missing slides in HTML presentation after #508#515jeertmans merged 5 commits intojeertmans:mainfrom
Conversation
|
@jeertmans, sorry for the multiple PRs. The minimal example I used to test #508 did not have enough slides so I was not able to discover this bug until now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 23 23
Lines 1962 1962
=======================================
Hits 1561 1561
Misses 401 401 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @Rapsssito, thanks for your contribution! Could you provide the MWE, so I can at least see the problem before merging this? |
|
@jeertmans, yes, sorry. You can test it with any presentation that is more than 5 slides long. |
|
Oh my bad, I forgot the I just have a suggestion for the CHANGELOG entry, otherwise it looks all good to me :-) |
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
|
Thanks! |
Description
Fixes a problem introduced by #508 where lazy loaded slides by RevealJS are never loaded.
Check List
Check all the applicable boxes: