-
-
Notifications
You must be signed in to change notification settings - Fork 69
Add subsection support across exporters #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
krystophny
wants to merge
83
commits into
jeertmans:main
Choose a base branch
from
krystophny:feature/subsections-pauses-rebased
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
384c44e
Add subsection support across exporters
krystophny d635e19
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 64a8e81
Remove PLAN.md per request
krystophny 1dad0ed
fix: resolve pre-commit lint and type check failures
krystophny c88e79b
docs: add example to next_subsection docstring
krystophny e16a7aa
chore: trigger CI checks
krystophny bf587f4
fix: address Codacy security and complexity warnings
krystophny 6d195f1
fix: add security annotations for Codacy static analyzer
krystophny 3b5b7b5
fix: properly secure subprocess usage with comprehensive validation
krystophny 3bdff00
fix: add Bandit security markers for subprocess usage
krystophny e9f8f05
fix: restore Click decorator chain for convert command
krystophny a142b81
feat: make subsections work by default and add SubsectionExample
krystophny 29308c3
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 57aca8b
fix: capture final subsection state in PDF when subsection_mode is none
krystophny 49b59a2
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ff50ca9
refactor: unify subsection modes to none/all and set all as default
krystophny a87111f
refactor: unify PDF and PowerPoint subsection flags into single --sub…
krystophny dd7dc86
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d941ae3
feat: unify subsection handling across all formats with single --subs…
krystophny d176105
docs: clarify SubsectionExample to better demonstrate accumulative be…
krystophny 2d420e4
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f532851
docs: correct SubsectionExample slide count to two slides
krystophny 8599c3b
docs: clarify that subtitle appears before subsections in SubsectionE…
krystophny 5ee7f70
docs: add comprehensive subsection usage documentation across all modes
krystophny 672073b
refactor: simplify RevealJS subsection mode to match PDF/PowerPoint p…
krystophny daa69f9
refactor: simplify Qt presenter subsection modes to match PDF/PowerPoint
krystophny 323f25e
refactor: RADICAL SIMPLIFICATION - HTML now creates separate sections…
krystophny 58a0c76
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 24488ea
fix: CRITICAL - make subsections accumulate content correctly
krystophny 33fc02a
fix: correct subsection marker placement in SubsectionExample
krystophny 0ccf4df
fix: add separate subsection for subtitle and differentiate title fro…
krystophny 7d3a008
fix: use self.clear() to properly clear screen between slides
krystophny 0c40493
fix: add clear() after first slide and update title on second slide
krystophny 2a6cb2d
fix: capture final video frame in PDF none mode instead of last subse…
krystophny 4f6dd7a
fix: remove duplicate final frame from PDF subsections all mode
krystophny 38cd73b
fix: add final frame after subsections in PDF all mode
krystophny 665c39d
feat: add third slide with subsections to SubsectionExample for bette…
krystophny 338418c
fix: PowerPoint tail fragment should show accumulated content from start
krystophny 6e4c789
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2c0a27d
style: improve slide titles with better font size and Write animation
krystophny 3e816a6
fix: move dot and triangle closer to center on third slide
krystophny aa80df2
fix: PowerPoint subsections show final frame only, not full animation
krystophny e9200b9
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fe9ca7f
fix: PowerPoint extracts full videos from 0 to end_time for each subs…
krystophny 20c2fd0
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 471e82d
fix: use frame-accurate video cuts for PowerPoint subsections
krystophny 8c99690
fix: PowerPoint shows single frame at each subsection end_time
krystophny fbfd4d1
fix: use last frame for PowerPoint poster image instead of first
krystophny 6cf7ca7
fix: add cut transition to PowerPoint slides to eliminate black flashes
krystophny d11ae3a
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 743c93f
fix: extract 0.5s segments for PowerPoint to avoid black flashes
krystophny c5982cf
fix: extract full videos from 0 to end_time for PowerPoint subsections
krystophny c46e173
fix: extract subsections from start_time to end_time for PowerPoint
krystophny f6cd61a
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c2edd67
Revert "fix: use last frame for PowerPoint poster image instead of fi…
krystophny 2d354de
fix: add one frame duration to end_time to include final frame
krystophny dce2a47
fix: remove extra frame, use exact start_time to end_time
krystophny 7bc5e99
fix: add epsilon to video extraction duration for inclusive end frame
krystophny 9e80001
feat: place subsections as sequential videos on single PowerPoint slide
krystophny fd3244b
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e1a457f
fix: remove video timing nodes for click-to-play subsections
krystophny 244ca7b
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 594df2f
fix: use subsection start_time and add tail section in HTML converter
krystophny f6b592a
fix: prevent black screen when loading slides with subsections in Qt …
krystophny 286e737
fix: extract video segments for HTML subsections with accurate timing
krystophny 3ed6732
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 779426a
feat: use Manim's next_section for subsections
krystophny e6a48e7
refactor: use partial animation files directly for subsections
krystophny 7407b26
fix: use subsection files in PDF converter
krystophny 0eab92a
fix: work around Manim incomplete animation bug in PDF
krystophny 4787b4e
fix: add wait after subsections to show completed animation
krystophny e859ec3
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6487fe3
polish: improve subsection implementation comments and tests
krystophny 5460b22
Handle PPTX subsections and prevent Qt fade
krystophny 512cbef
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5eb6093
fix: create vertical slides for subsections in HTML export
krystophny 3000d23
fix: remove unrelated Qt presenter item from CHANGELOG
krystophny e00ae66
fix: only call wait() in next_subsection when animations exist
krystophny 6057569
fix: Qt presenter subsection handling issues
krystophny 0efcd0b
fix: extract tail video segment for HTML export
krystophny d67c5f9
chore(fmt): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8ef2b83
fix: remove frame freeze from load_next_slide to prevent black frames
krystophny 7c0b9a3
fix: add wait_time_between_slides to SubsectionExample for complete f…
krystophny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it AI generated? I am asking because the "changed" section does not make much sense: we did not change the defaults, because most of them did not exist previously.