Skip to content

feat(lib/html): adding vertical slides to export to html#602

Merged
jeertmans merged 42 commits intojeertmans:mainfrom
daughterOfSpring:main
Feb 24, 2026
Merged

feat(lib/html): adding vertical slides to export to html#602
jeertmans merged 42 commits intojeertmans:mainfrom
daughterOfSpring:main

Conversation

@daughterOfSpring
Copy link
Contributor

@daughterOfSpring daughterOfSpring commented Feb 20, 2026

Fixes Issue

Addresses Issue #570

Description

  • Adding direction kwarg to next slide function
  • Adding direction to BaseSlideConfig

Check List

Check all the applicable boxes:

  • I understand that my contributions needs to pass the checks;
  • If I created new functions / methods, I documented them and add type hints;
  • If I modified already existing code, I updated the documentation accordingly;
  • The title of my pull request is a short description of the requested changes.

Note to reviewers

This is a work in progress, I am still unable to get slides exporting in the correct direction

@daughterOfSpring
Copy link
Contributor Author

daughterOfSpring commented Feb 20, 2026

At this point I'm not really sure where to go, I can't seem to get the direction to be communicated from the nextSlide function to the revealjs code that builds the html. I'm sure I'm missing something, but I'm going to need to keep looking into this before its ready to merge.

At this point in addition the additions mentioned in my first post in this PR I have also:

  • Added a loop to the revealjs.html script that creates additional section tags whenever it detects that the user is attempting to create vertical slides.

@daughterOfSpring daughterOfSpring marked this pull request as draft February 20, 2026 17:29
@daughterOfSpring daughterOfSpring changed the title Adding direction to slide export Adding vertical slides to export to html Feb 20, 2026
Copy link
Owner

@jeertmans jeertmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daughterOfSpring, thanks for your contribution! I think the confusion about your PR currently not working is related to the mystic behavior of the BaseSlideConfig.wrapper, see my comments below. I hope it helps!
Other than that, the PR looks great :)

@daughterOfSpring daughterOfSpring marked this pull request as ready for review February 21, 2026 23:32
@jeertmans jeertmans changed the title Adding vertical slides to export to html feat(lib/html): adding vertical slides to export to html Feb 22, 2026
@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.11%. Comparing base (33f20fe) to head (4b7e6cf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   79.10%   79.11%   +0.01%     
==========================================
  Files          23       23              
  Lines        2039     2040       +1     
==========================================
+ Hits         1613     1614       +1     
  Misses        426      426              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeertmans
Copy link
Owner

Looks great @daughterOfSpring, thanks! To wrap up, could you add a entry to the changelog to document your change? It can go inside the # Added section.

daughterOfSpring and others added 2 commits February 22, 2026 13:55
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
@daughterOfSpring
Copy link
Contributor Author

Looks great @daughterOfSpring, thanks! To wrap up, could you add a entry to the changelog to document your change? It can go inside the # Added section.

I can but which release do I put it under?

CHANGELOG.md Outdated
Comment on lines +28 to +30
### Added
* Added vertical slide implementation to html exports of presentations. [@DaughterOfSpring](https://github.com/daughterOfSpring) [#602](https://github.com/jeertmans/manim-slides/pull/602)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to move this under the # Unreleased section, since your changes are not yet released :-)

@daughterOfSpring
Copy link
Contributor Author

Are these tests failing due to my changes?

@jeertmans
Copy link
Owner

Are these tests failing due to my changes?

No, don't worry, those tests are failing for unrelated reasons.

Could you check this #602 (comment)? After you move the changelog entry to the correct position, I think it can be merged :-)

@jeertmans
Copy link
Owner

Looks great, thank you so much for your contribution @daughterOfSpring!

@jeertmans jeertmans merged commit e378c34 into jeertmans:main Feb 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

html-convert Related to converting to HTML slides lib Related to the library (a.k.a. module) python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants