feat(lib/html): adding vertical slides to export to html#602
feat(lib/html): adding vertical slides to export to html#602jeertmans merged 42 commits intojeertmans:mainfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
At this point I'm not really sure where to go, I can't seem to get the direction to be communicated from the nextSlide function to the revealjs code that builds the html. I'm sure I'm missing something, but I'm going to need to keep looking into this before its ready to merge. At this point in addition the additions mentioned in my first post in this PR I have also:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
jeertmans
left a comment
There was a problem hiding this comment.
Hi @daughterOfSpring, thanks for your contribution! I think the confusion about your PR currently not working is related to the mystic behavior of the BaseSlideConfig.wrapper, see my comments below. I hope it helps!
Other than that, the PR looks great :)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 79.10% 79.11% +0.01%
==========================================
Files 23 23
Lines 2039 2040 +1
==========================================
+ Hits 1613 1614 +1
Misses 426 426 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks great @daughterOfSpring, thanks! To wrap up, could you add a entry to the changelog to document your change? It can go inside the |
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
I can but which release do I put it under? |
CHANGELOG.md
Outdated
| ### Added | ||
| * Added vertical slide implementation to html exports of presentations. [@DaughterOfSpring](https://github.com/daughterOfSpring) [#602](https://github.com/jeertmans/manim-slides/pull/602) | ||
|
|
There was a problem hiding this comment.
You need to move this under the # Unreleased section, since your changes are not yet released :-)
|
Are these tests failing due to my changes? |
No, don't worry, those tests are failing for unrelated reasons. Could you check this #602 (comment)? After you move the changelog entry to the correct position, I think it can be merged :-) |
|
Looks great, thank you so much for your contribution @daughterOfSpring! |
Fixes Issue
Addresses Issue #570
Description
Check List
Check all the applicable boxes:
Note to reviewers
This is a work in progress, I am still unable to get slides exporting in the correct direction