WIP / Hackathon: ODB over IPC

.gitignore

@@ -112,6 +112,7 @@
 /git-mv
 /git-name-rev
 /git-notes
+/git-odb--daemon
 /git-p4
 /git-pack-redundant
 /git-pack-objects

Makefile

@@ -936,6 +936,7 @@ LIB_OBJS += notes.o
 LIB_OBJS += object-file.o
 LIB_OBJS += object-name.o
 LIB_OBJS += object.o
+LIB_OBJS += odb-over-ipc.o
 LIB_OBJS += oid-array.o
 LIB_OBJS += oidmap.o
 LIB_OBJS += oidset.o
@@ -1119,6 +1120,7 @@ BUILTIN_OBJS += builtin/multi-pack-index.o
 BUILTIN_OBJS += builtin/mv.o
 BUILTIN_OBJS += builtin/name-rev.o
 BUILTIN_OBJS += builtin/notes.o
+BUILTIN_OBJS += builtin/odb--daemon.o
 BUILTIN_OBJS += builtin/pack-objects.o
 BUILTIN_OBJS += builtin/pack-redundant.o
 BUILTIN_OBJS += builtin/pack-refs.o

builtin.h

@@ -188,6 +188,7 @@ int cmd_multi_pack_index(int argc, const char **argv, const char *prefix);
 int cmd_mv(int argc, const char **argv, const char *prefix);
 int cmd_name_rev(int argc, const char **argv, const char *prefix);
 int cmd_notes(int argc, const char **argv, const char *prefix);
+int cmd_odb__daemon(int argc, const char **argv, const char *prefix);
 int cmd_pack_objects(int argc, const char **argv, const char *prefix);
 int cmd_pack_redundant(int argc, const char **argv, const char *prefix);
 int cmd_patch_id(int argc, const char **argv, const char *prefix);

builtin/fsmonitor--daemon.c

@@ -996,10 +996,24 @@ static int do_handle_client(struct fsmonitor_daemon_state *state,
 
 static ipc_server_application_cb handle_client;
 
-static int handle_client(void *data, const char *command,
+static int handle_client(void *data,
+			 const char *command, size_t command_len,
 			 ipc_server_reply_cb *reply,
 			 struct ipc_server_reply_data *reply_data)
 {
+	// TODO I did not take time to ensure that `command_len` is
+	// TODO large enough to do all of the strcmp() and starts_with()
+	// TODO calculations when I converted the IPC API to take
+	// TODO `command, command_len` rather than just `command`.
+	// TODO So some cleanup is needed here.
+	// TODO
+	// TODO But we know that FSMonitor always uses regular text
+	// TODO in both the request and response (no binary messages
+	// TODO here), so the cleanup is more of the `assert` form.
+	// TODO
+	// TODO For example, I should pass `command, command_len` into
+	// TODO `do_handle_client()` for completeness.
+
 	struct fsmonitor_daemon_state *state = data;
 	int result;