fix(tokens): hardcoded kleur- en schaduwfallbacks in table.css vervangen#90
Merged
jeffreylauwers merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
- Verwijder hardcoded #fcfcfc fallback uit --_bg: gebruikt nu direct var(--dsn-color-neutral-bg-document) zonder fallback - Vervang hardcoded rgba(0,0,0,0.15) door var(--dsn-color-shadow-scroll) zodat dark mode de lichte schaduw (rgba(255,255,255,0.12)) gebruikt - Update comment: scroll-shadow is nu volledig getoken De tokens dsn.color.shadow.scroll bestonden al in beide thema's (colors-light.json + colors-dark.json) — alleen de CSS-referentie ontbrak. Closes #86 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#fcfcfcfallback —--_bggebruikt nuvar(--dsn-color-neutral-bg-document)zonder hardcoded waardergba(0, 0, 0, 0.15)doorvar(--dsn-color-shadow-scroll)— dark mode krijgt nu automatischrgba(255, 255, 255, 0.12)(lichte schaduw op donkere achtergrond)Opmerking:
dsn.color.shadow.scrollbestond al in beide thema's — alleen de CSS-referentie intable.cssontbrak.Closes #86
Test plan
pnpm test— 1008 tests groenpnpm --filter storybook exec tsc --noEmit— 0 foutenpnpm lint— 0 fouten🤖 Generated with Claude Code