Skip to content

Get path for first page of paginated pages #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Get path for first page of paginated pages #219

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
982091a
Get path for first page of paginated pages (fixes #213)
cmbuckley Dec 22, 2021
eeff3bb
Fix rubocop comments
cmbuckley Dec 22, 2021
197b054
Update to .each and remove use of .dup
cmbuckley Dec 22, 2021
cb7c164
Add test for path of paginated page
cmbuckley Dec 23, 2021
e23323f
fixture_helper: use just tap in make_page
parkr Apr 4, 2023
16e82e4
Set page dir directly in spec helper
cmbuckley Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/jekyll-github-metadata/edit-link-tag.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ def self.def_hash_delegator(hash_method, key, method, default = nil)
private def_hash_delegator :site_github, :source, :source, {}
private def_hash_delegator :source, :branch, :branch
private def_hash_delegator :source, :path, :source_path
private def_hash_delegator :page, :path, :page_path

def render(context)
@context = context
Expand Down Expand Up @@ -72,6 +71,14 @@ def parts
memoize_conditionally { [repository_url, "edit/", branch, source_path, page_path] }
end

def page_path
return page["path"] unless page["paginated"]

site.pages.dup.select do |page|
return page["path"] if page.pager && page.pager.page == 1
end
end

def parts_normalized
memoize_conditionally do
parts.map.with_index do |part, index|
Expand Down