Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Bluetooth related filters - needs BLUETOOTH permission | ||
| addAction(BluetoothA2dp.ACTION_CONNECTION_STATE_CHANGED) | ||
| addAction(BluetoothHeadset.ACTION_AUDIO_STATE_CHANGED) | ||
| addAction(BluetoothHearingAid.ACTION_CONNECTION_STATE_CHANGED) |
Check warning
Code scanning / Android Lint
Using inlined constants on older versions Warning
|
I'm happy to test this. I see there's two APKs generated by the CI build, one is |
|
The main difference between libre/proprietary is chromecast support. There may be other differences but that's the one I know of |
|
No dice, sadly--I get the same behavior on this debug build as I do on the release version. |
Thank you for testing, it seems not possibly due to not using new enough API I think? But I'm also not very familiar with this. When I have time I will look into if there's a way to upgrade |
app/build.gradle.kts
Outdated
|
|
||
| defaultConfig { | ||
| minSdk = 21 | ||
| minSdk = 29 |
There was a problem hiding this comment.
We'll keep the minimum SDK version at 21 for the next release and increase it to 23 afterwards. There are no plans to set it even higher in the foreseeable future.
There was a problem hiding this comment.
Makes sense, I think in that case hearing aid support is not possible
There was a problem hiding this comment.
You should be able to simply wrap the code using new APIs with AndroidVersion.isAtLeast* methods, this way you can support hearing aids on newer versions without impacting older versions.
There was a problem hiding this comment.
thanks for the suggestion, was in the middle of a move but just got a chance to add this
Maxr1998
left a comment
Maxr1998
left a comment
There was a problem hiding this comment.
Thanks for the changes. There's one more comment that needs to be resolved. Please also make sure that our linter passes, you can run it locally with ./gradlew detekt. You should also reformat the code once more in Android Studio, the default configuration should fix most of the style issues which detekt will report already.
app/src/main/java/org/jellyfin/mobile/webapp/RemotePlayerService.kt
Outdated
Show resolved
Hide resolved
5 participants
Changes
Add BluetoothHearingAid device (https://developer.android.com/reference/android/bluetooth/BluetoothHearingAid?hl=en#ACTION_CONNECTION_STATE_CHANGED) to the playback manager.
I do not have a hearing aid so I cannot test if it fixes the bug...
Issues
Attempts to fix #1836