fix(player): re-detect audio and subs#1087
Open
Rijul-A wants to merge 2 commits intojellyfin:masterfrom
Open
Conversation
In the event that another addon (or even the user) sets the subtitles or the audio before this addon does, such a change is not detected correctly. This PR fixes that by reloading that information from Kodi before calling `set_audio_subs`
|
oddstr13
requested changes
Feb 4, 2026
Member
oddstr13
left a comment
oddstr13
left a comment
There was a problem hiding this comment.
This PR contains unrelated changes that are not mentioned in the PR text.
While the change in the build script is technically a bug fix, it is also not actually broken as-is.
I have not reviewed nor validated the proposed subtitle changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event that another addon (or even the user) sets the subtitles or
the audio before this addon does, such a change is not detected
correctly.
This PR fixes that by reloading that information from Kodi before
calling
set_audio_subs. It only impacts the Addon Player mode.