Skip to content

feat: add frame scrubbing controls#7315

Open
flying-sheep wants to merge 17 commits intojellyfin:masterfrom
flying-sheep:scrub
Open

feat: add frame scrubbing controls#7315
flying-sheep wants to merge 17 commits intojellyfin:masterfrom
flying-sheep:scrub

Conversation

@flying-sheep
Copy link

@flying-sheep flying-sheep commented Nov 8, 2025

Changes
Register , and . as controls to scrub frame-by-frame.

These are the same keys that YouTube uses for this functionality, which seems to be the interface you’re mirroring with these keybinds.

Issues
Resolves #3087, closes #7132
Implements https://features.jellyfin.org/posts/3545/seeking-video-frame-by-frame

TODO:

  • Use current media stream FPS to calculate ticks to jump forward/backward

@flying-sheep flying-sheep requested a review from a team as a code owner November 8, 2025 18:07
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 8, 2025

Cloudflare Pages deployment

Latest commit ecef614
Status ✅ Deployed!
Preview URL https://1baff9e2.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

@flying-sheep
Copy link
Author

OK! Ready for review now!

@flying-sheep
Copy link
Author

@thornbill what do I have to do to get some eyes on this?

Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions.

Thanks for your patience as I've been busy with real-life stuff.

@thornbill thornbill added this to the v10.12.0 milestone Dec 5, 2025
@thornbill thornbill added feature New feature or request playback This PR or issue mainly concerns playback labels Dec 5, 2025
flying-sheep and others added 2 commits December 6, 2025 14:10
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
@flying-sheep
Copy link
Author

Thank you for taking a look! Sorry for being annoying and contacting you repeatedly. Hope your life stuff is turning out well!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2025

@flying-sheep
Copy link
Author

Hia @thornbill do you think this is ready now?

@flying-sheep flying-sheep requested a review from thornbill March 4, 2026 21:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request playback This PR or issue mainly concerns playback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow per-frame playback navigation

3 participants