Skip to content

Update Node.js version in GitHub Actions workflow #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drizzentic merged 1 commit into from
Mar 12, 2026
Merged

Update Node.js version in GitHub Actions workflow #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

strategy:
matrix:
node-version: [14.x]
node-version: [18.x]
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify that the matrix value is unused and the image build still pins Node 18.
rg -nC2 'node-version|matrix\.node-version|setup-node' .github/workflows/master.yml
sed -n '1,5p' Dockerfile

Repository: jembi/openhim-console

Length of output: 230

Remove the unused matrix entry or add the corresponding Dockerfile update.

The node-version matrix on Line 16 is declared but never referenced in the workflow (no ${{ matrix.node-version }} or setup-node step exists). The build still uses FROM node:18-alpine from the Dockerfile, which is EOL. Either remove this unused matrix configuration or, if the intent is to upgrade Node, update the Dockerfile to a supported version (e.g., 24.x) and wire it into the workflow.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/master.yml at line 16, The workflow defines an unused
matrix entry "node-version" but never references it; either remove the
node-version matrix key from the GitHub Actions workflow or update the
Dockerfile and workflow to use the matrix value. To fix: if you want to keep the
matrix, change the Dockerfile FROM line from "FROM node:18-alpine" to a
supported image (e.g., node:24-alpine) and add a setup step or interpolation
that uses "${{ matrix.node-version }}" (or reference the matrix when building
the Docker image) so the matrix is actually used; otherwise simply delete the
"node-version" matrix entry from the workflow to remove the unused
configuration. Ensure you update any CI steps that build the image or reference
node to use the same node version symbol ("node-version" / FROM node:<version>)
so they remain consistent.


steps:
- uses: actions/checkout@v3
Expand All @@ -39,4 +39,4 @@ jobs:
file: ./Dockerfile
platforms: linux/amd64,linux/arm64
push: true
tags: jembi/openhim-console:latest
tags: jembi/openhim-console:latest
Loading