Fix: Prevent app crash when external CSV is empty in ThankYouNote #565
Open
madhuri-perumalla wants to merge 2 commits intojenkins-infra:mainfrom
Open
Fix: Prevent app crash when external CSV is empty in ThankYouNote #565madhuri-perumalla wants to merge 2 commits intojenkins-infra:mainfrom
madhuri-perumalla wants to merge 2 commits intojenkins-infra:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ThankYouNote component was directly accessing parsed CSV data without checking if it exists:
----> If the CSV is empty or only contains headers, data[1] becomes undefined.
----> This later causes runtime errors when the code tries to access values like undefined[6].
Fixes
Added a validation step to ensure the parsed data exists and contains at least one data row before setting the state:
Result