Skip to content

Fix nested links in search results markup#567

Open
Rohan-Ver-ma wants to merge 2 commits intojenkins-infra:mainfrom
Rohan-Ver-ma:fix/search-results-nested-a-tag
Open

Fix nested links in search results markup#567
Rohan-Ver-ma wants to merge 2 commits intojenkins-infra:mainfrom
Rohan-Ver-ma:fix/search-results-nested-a-tag

Conversation

@Rohan-Ver-ma
Copy link
Copy Markdown

@Rohan-Ver-ma Rohan-Ver-ma commented Mar 20, 2026

Description

This PR fixes invalid nested link markup in search result cards by separating profile navigation Links from social anchor links.

Fixes

#566

What was done:

  • Updated [SearchResults.jsx]to remove the outer Link wrapping the full card.
  • Kept contributor profile navigation Links around profile content only.
  • Left social links as standalone external anchors (GitHub/LinkedIn/X), avoiding anchor-inside-anchor structure.
  • Removed unused score argument from the map callback (sorting by score is still preserved before rendering).

Result:

  • Valid interactive structure.
  • Cleaner render logic.
  • No behavior change to sorting or social link actions.

Checklist

  • PR title is clear and descriptive
  • Changes follow project conventions
  • No unrelated changes included
  • Ran both link and format checks

@Rohan-Ver-ma Rohan-Ver-ma requested a review from a team as a code owner March 20, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Rohan-Ver-ma