Skip to content

chore: switch from @halkeye/jenkins-io-components to @jenkinsci/jenkins-io-components#37

Merged
lemeurherve merged 1 commit intomainfrom
lemeurherve-patch-1
Nov 24, 2022
Merged

chore: switch from @halkeye/jenkins-io-components to @jenkinsci/jenkins-io-components#37
lemeurherve merged 1 commit intomainfrom
lemeurherve-patch-1

Conversation

@lemeurherve
Copy link
Contributor

Follow-up of #32

Ref: jenkins-infra/helpdesk#3250

@halkeye
Copy link
Member

halkeye commented Nov 24, 2022

I'm kinda conflicted here. On one hand yes, so much yes.
On the other hand, i'm doing a bunch of refactoring to make algolia v3 work in the web components, so would like to wait a day or two.

@lemeurherve
Copy link
Contributor Author

This PR can wait of course 🙂

@lemeurherve lemeurherve marked this pull request as draft November 24, 2022 00:32
@halkeye
Copy link
Member

halkeye commented Nov 24, 2022

jenkins-infra/jenkins.io#5668 seems good and reliable now. Full alogila v3 support (when attribute enables it)

So go ahead and merge when you want.

@lemeurherve lemeurherve marked this pull request as ready for review November 24, 2022 08:39
@lemeurherve lemeurherve merged commit 6e0472a into main Nov 24, 2022
@lemeurherve lemeurherve deleted the lemeurherve-patch-1 branch November 24, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants