- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.4k
 
feat: Add .NET Tutorial #7977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add .NET Tutorial #7977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that there are chunks of content here that are copied over from the Maven tutorial. For instance, there is a large section of "Create your initial Pipeline as a Jenkinsfile" which reads as though it was copied with only minimal changes made.
Additionally, when forking the sample repository a completely updated Jenkinsfile is included, defeating the purpose of the tutorial. I also don't see a build step in the pipeline overview despite it being included

This is after a clean fork of the original repository and running the Build (without making any changes to the completed jenkinsfile).
The screenshots are far too small to be readable by users and must be more focused so that the content is visible. Right now, I have to zoom in quite a bit to even read what is being displayed.

The capture here is also far too wide on the screen, as there is a ton of blank space to the right of the actual build status information, which is unnecessary.
There may be other changes needed, but these are my initial findings.
| 
           Thank you. I'll revise the sample repository and the tutorial. I wonder how the better approach for capturing the screenshot.  | 
    
| 
           Hi @berviantoleo, for the screenshots, I would recommend resizing the window to a smaller size so that there is not so much blank space on the page. Additionally, if you use a screenshot tool to capture just a section of the screen, instead of the full screen, it will help focus on the content that matters. For instance, the first-build-details screenshot could be more focused on the build details and captured closer to how the artifacts screenshot displays. The thing to keep in mind is that not everyone will be using the same size/resolution monitor and therefore screenshots can change very easily depending on the users hardware.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @berviantoleo for your work and updates on this. I've provided a couple further suggestions regarding the text/screenshots. Approving pending those updates.
Co-authored-by: Kevin Martens <[email protected]>
| 
           When this tutorial is nearly ready for merging, we should migrate the code repository to the  Thanks!  | 
    
| 
           @gounthar should that happen prior to merge or after the merge has taken place? I want to be sure we make this as easy as possible since we've learned from last time.  | 
    
| 
           We can reference Bervianto's repository, but I would prefer to merge this PR after the repository has been migrated. This will ensure that we don't overlook the migration step.  | 
    
| 
           @berviantoleo could you please make me an admin/maintainer/co-author/anything that would allow me to migrate your repo to the jenkins-docs organization?  | 
    
          
 @gounthar  | 
    
| 
           Please go ahead this way, then.  | 
    
| 
           Thanks a lot, Bervianto.  | 
    

Part of
See https://deploy-preview-7977--jenkins-io-site-pr.netlify.app/doc/tutorials/build-a-dotnet-web-app-with-jenkins/ for the preview.