hotfix(infra.getBuildAgentLabel): no spot/nonspot label when called from trusted.ci.jenkins.io

[lemeurherve]

This change prevents the addition of "spot" or "nonspot" when called from trusted.ci.jenkins.io as none of its (Azure) agent templates include any of these labels.

Noticed on https://trusted.ci.jenkins.io/job/Containers/job/Agents/job/docker-agents/job/3355.v388858a_47b_33-8/1/consoleFull

Amends:

• feat(infra.getBuildAgentLabel): add docker jobs labels #980

Related:

• chore(pipeline): use infra.getBuildAgentLabel in agentSelector jenkinsci/docker-agents#1137 ¹
• feat(acceptance-tests/trusted.ci): use pipeline and checks scripts from ci.jenkins.io acceptance-tests#49 (comment)

Testing done

• Updated requirements in tests with e0124ce, mvn test fails (as expected) ❌

[ERROR]   InfraStepTests.testGetBuildAgentLabel:579 Unexpected result for case: [platform:windows-2019, container:false, trustedEnv:true, expected:windows-2019, warning:null] expected:<windows-2019[]> but was:<windows-2019[ && spot]>
[ERROR]   InfraStepTests.testGetBuildAgentLabel:579 Unexpected result for case: [platform:windows-2025, container:false, trustedEnv:true, retry:2, expected:windows-2025, warning:null] expected:<windows-2025[]> but was:<windows-2025[ && nonspot]>

• After the fix from d623b4a, mvn test passes ✅

Footnotes

1. I should have tested a dry-run on trusted.ci.jenkins.io first, my mistake, sorry. ↩

[lemeurherve]

Confirmed working: https://trusted.ci.jenkins.io/job/Containers/job/Agents/job/docker-agents/job/3355.v388858a_47b_33-8/2 got proper agents provisioned.