fix: proper URLs in https://updates.jenkins.io/index.html#907
Conversation
|
How does this relate to #670 and does the feedback I left there also apply here? In general, I'd like an opportunity to review PRs in this repo unless it concerns purely the infra distribution site, or is urgent. This seems to be neither. |
…)" This reverts commit 4aeef31.
Taking a look. (did not notice this PR before)
My bad sorry, noted! |
@daniel-beck: yes and yes, reworking my fix. Opened a revert PR meanwhile: #908 |
@daniel-beck can you review either #908 or #909 to restore update_center jobs on trusted.ci.jenkins.io please? |
|
I guess #908 will do until I've had an opportunity to review the other. |
This change replaces the relative URLs in URLs and footer of the base HTML fetched from https://www.jenkins.io/templates/updates/index.html defined in https://github.com/jenkins-infra/jenkins.io/blob/master/content/templates/updates.adoc by absolute ones, and set the proper attributes for jio-components.
Ref:
Testing done
Then opened index-fixed-links.html in a browser to check that all links in the navbar (notably the "Security" ones), in the body ("See Publishing Experimental Plugin Releases for more information.") and in the footer correctly point to jenkins.io if need, and that "Report an issue" has the correct info passed to the issue template of jenkins.io1.
Footnotes
I initially wanted to point it to an helpdesk issue, but the helpesk template doesn't have a
problemfield, and jio-component doesn't have any attribute likesourcepathto also define the field to fill. ↩