Skip to content

fix: proper URLs in https://updates.jenkins.io/index.html#907

Merged
lemeurherve merged 1 commit intojenkins-infra:masterfrom
lemeurherve:helpdesk4882-absolute-links-in-header-and-footer
Feb 23, 2026
Merged

fix: proper URLs in https://updates.jenkins.io/index.html#907
lemeurherve merged 1 commit intojenkins-infra:masterfrom
lemeurherve:helpdesk4882-absolute-links-in-header-and-footer

Conversation

@lemeurherve
Copy link
Contributor

@lemeurherve lemeurherve commented Feb 23, 2026

This change replaces the relative URLs in URLs and footer of the base HTML fetched from https://www.jenkins.io/templates/updates/index.html defined in https://github.com/jenkins-infra/jenkins.io/blob/master/content/templates/updates.adoc by absolute ones, and set the proper attributes for jio-components.

Ref:

Testing done

$ wget -q --convert-links -O index-original.html --convert-links https://www.jenkins.io/templates/updates/index.html
$ cp index-original.html index-fixed-links.html
$ sed -i '' \
  -e 's|href="/|href="https://www.jenkins.io/|g' \
  -e 's|property="https://www.jenkins.io"|property="https://updates.jenkins.io"|g' \
  -e 's|sourcepath=""|sourcepath="content/templates/updates.adoc"|' \
  index-fixed-links.html

Then opened index-fixed-links.html in a browser to check that all links in the navbar (notably the "Security" ones), in the body ("See Publishing Experimental Plugin Releases for more information.") and in the footer correctly point to jenkins.io if need, and that "Report an issue" has the correct info passed to the issue template of jenkins.io1.

Footnotes

  1. I initially wanted to point it to an helpdesk issue, but the helpesk template doesn't have a problem field, and jio-component doesn't have any attribute like sourcepath to also define the field to fill.

@lemeurherve lemeurherve merged commit 4aeef31 into jenkins-infra:master Feb 23, 2026
2 checks passed
@lemeurherve lemeurherve deleted the helpdesk4882-absolute-links-in-header-and-footer branch February 23, 2026 15:07
@daniel-beck
Copy link
Contributor

How does this relate to #670 and does the feedback I left there also apply here?

In general, I'd like an opportunity to review PRs in this repo unless it concerns purely the infra distribution site, or is urgent. This seems to be neither.

@lemeurherve
Copy link
Contributor Author

lemeurherve commented Feb 23, 2026

How does this relate to #670 and does the feedback I left there also apply here?

Taking a look. (did not notice this PR before)

In general, I'd like an opportunity to review PRs in this repo unless it concerns purely the infra distribution site, or is urgent. This seems to be neither.

My bad sorry, noted!

@lemeurherve
Copy link
Contributor Author

lemeurherve commented Feb 23, 2026

How does this relate to #670 and does the feedback I left there also apply here?

@daniel-beck: yes and yes, reworking my fix.

Opened a revert PR meanwhile: #908

@lemeurherve
Copy link
Contributor Author

lemeurherve commented Feb 23, 2026

In general, I'd like an opportunity to review PRs in this repo unless it concerns purely the infra distribution site, or is urgent.

@daniel-beck can you review either #908 or #909 to restore update_center jobs on trusted.ci.jenkins.io please?

@daniel-beck
Copy link
Contributor

daniel-beck commented Feb 23, 2026

I guess #908 will do until I've had an opportunity to review the other.

daniel-beck pushed a commit that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants