Skip to content

Ban JUnit 4 imports#94

Merged
strangelookingnerd merged 1 commit intomainfrom
strangelookingnerd-patch-1
Aug 18, 2025
Merged

Ban JUnit 4 imports#94
strangelookingnerd merged 1 commit intomainfrom
strangelookingnerd-patch-1

Conversation

@strangelookingnerd
Copy link
Copy Markdown
Contributor

Ban JUnit 4 imports

To prevent regressions when adding new tests, jenkinsci/plugin-pom#1178 introduced a new flag that enables a Maven Enforcer rule banning org.junit.* imports while allowing org.junit.jupiter.*.

With this change, the build will fail if any org.junit.* imports are introduced.

Testing done

None. Rely on ci.jenkins.io.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner August 18, 2025 07:22
@strangelookingnerd strangelookingnerd added the documentation Improvements or additions to documentation label Aug 18, 2025
@strangelookingnerd strangelookingnerd merged commit 2c29e95 into main Aug 18, 2025
17 checks passed
@strangelookingnerd strangelookingnerd deleted the strangelookingnerd-patch-1 branch August 18, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant