Skip to content

Adding parent-child job support to the pipeline job. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 9, 2025
Merged

Adding parent-child job support to the pipeline job. #92

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
41efd1f
[maven-release-plugin] prepare release bstack
sanjay000001 Jan 13, 2025
9df77f8
[maven-release-plugin] prepare for next development iteration
sanjay000001 Jan 13, 2025
6abe177
Merge branch 'master' of https://github.com/jenkinsci/browserstack-in…
sanjay000001 May 26, 2025
cc13d94
[maven-release-plugin] prepare release browserstack-integration-1.2.19
sanjay000001 May 26, 2025
691cdaa
[maven-release-plugin] prepare for next development iteration
sanjay000001 May 26, 2025
cd1fb7c
Parent child relationship
sanjay000001 Jun 3, 2025
c1f4865
Reverting the pom.xml file changes
sanjay000001 Jun 4, 2025
a8fcb9f
Adding a try-catch while resolving parent-child relationship.
sanjay000001 Jun 4, 2025
b1d7a80
Added Support for Multi-Configuration/Matrix Job and artifacts handling
sanjay000001 Jun 6, 2025
5056c1a
Adding Caching for QD Enabled and check for Creds
sanjay000001 Jun 10, 2025
bddc072
Using Instant time module for cache expiry.
sanjay000001 Jun 12, 2025
5df30d4
Replacing System.print to Logger.info
sanjay000001 Jun 13, 2025
25cc14b
Sending the job type to QEI.
sanjay000001 Jun 18, 2025
bea898d
Adding try-catch around the getItemType
sanjay000001 Jun 19, 2025
e2cad42
Sending job type at the initials set-up and item creation steps, and …
sanjay000001 Jun 19, 2025
631cf69
changing logger method from info to warning.
sanjay000001 Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...main/java/com/browserstack/automate/ci/jenkins/qualityDashboard/QualityDashboardInit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ private static void initQDSetupIfRequired() throws JsonProcessingException {
apiUtil.logToQD(browserStackCredentials,"Starting plugin data export to QD");
checkQDIntegrationAndDumpMetaData(browserStackCredentials);
} else {
LOGGER.info("BrowserStack credentials not found. Skipping Quality Dashboard initialization.");
LOGGER.warning("BrowserStack credentials not found. Skipping Quality Dashboard initialization.");
}
} catch (Exception e) {
try {
Expand Down Expand Up @@ -143,15 +143,15 @@ private static List<PipelineInfo> getAllPipelines(BrowserStackCredentials browse

} catch (JsonProcessingException e) {
// Handling the exception and logging an error
LOGGER.info("Error processing JSON for job: " + job.getName() + " - " + e.getMessage());
LOGGER.warning("Error processing JSON for job: " + job.getName() + " - " + e.getMessage());
e.printStackTrace();
}
});
} else {
try {
apiUtil.logToQD(browserStackCredentials, "Issue getting Jenkins Instance");
} catch (JsonProcessingException e) {
LOGGER.info("Error logging issue with Jenkins instance.");
LOGGER.warning("Error logging issue with Jenkins instance.");
Copy link

@karanshah-browserstack karanshah-browserstack Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be error?

Copy link
Contributor Author

@sanjay000001 sanjay000001 Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karanshah-browserstack, We are logging this as a warning instead of an error because the logs appear on the user's Jenkins system. We want to avoid showing error logs to the user.

e.printStackTrace();
}
}
Expand All @@ -161,7 +161,7 @@ private static List<PipelineInfo> getAllPipelines(BrowserStackCredentials browse
apiUtil.logToQD(browserStackCredentials,"Total Pipelines detected : " + allPipelines.size());
} catch (JsonProcessingException e) {
// Handling the exception and logging an error
LOGGER.info("Error processing JSON for total pipelines: " + e.getMessage());
LOGGER.warning("Error processing JSON for total pipelines: " + e.getMessage());
e.printStackTrace();
}
// Returning the list of filtered pipelines
Expand Down Expand Up @@ -223,7 +223,7 @@ private static List<PipelineDetails> getAllBuilds(BrowserStackCredentials browse
rootUpstreamProject = UpstreamPipelineResolver.resolveRootUpstreamProject(build, browserStackCredentials);
immediateParentProject = UpstreamPipelineResolver.resolveImmediateUpstreamProjectForQEI(build, browserStackCredentials);
} catch (Exception e) {
LOGGER.info("Error resolving upstream project for " + pipelineName + " build number " + buildNumber + ": " + e.getMessage());
LOGGER.warning("Error resolving upstream project for " + pipelineName + " build number " + buildNumber + ": " + e.getMessage());
e.printStackTrace();
}
PipelineDetails pipelineDetail = new PipelineDetails(pipelineName, buildNumber, duration, result,
Expand Down
10 changes: 5 additions & 5 deletions ...m/browserstack/automate/ci/jenkins/qualityDashboard/QualityDashboardInitItemListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void onCreated(Item job) {
try {
BrowserStackCredentials browserStackCredentials = QualityDashboardUtil.getBrowserStackCreds();
if(browserStackCredentials == null) {
LOGGER.info("BrowserStackCredentials not found. Please ensure they are configured correctly.");
LOGGER.warning("BrowserStackCredentials not found. Please ensure they are configured correctly.");
return;
}
QualityDashboardAPIUtil apiUtil = new QualityDashboardAPIUtil();
Expand All @@ -39,7 +39,7 @@ public void onCreated(Item job) {
syncItemListToQD(jsonBody, Constants.QualityDashboardAPI.getItemCrudEndpoint(), "POST");

} catch(Exception e) {
LOGGER.info("Error syncing item creation to Quality Dashboard: " + e.getMessage());
LOGGER.warning("Error syncing item creation to Quality Dashboard: " + e.getMessage());
e.printStackTrace();
}
} else {
Expand All @@ -59,7 +59,7 @@ public void onDeleted(Item job) {
String jsonBody = getJsonReqBody(new ItemUpdate(itemName, itemType));
syncItemListToQD(jsonBody, Constants.QualityDashboardAPI.getItemCrudEndpoint(), "DELETE");
} catch(Exception e) {
LOGGER.info("Error syncing item deletion to Quality Dashboard: " + e.getMessage());
LOGGER.warning("Error syncing item deletion to Quality Dashboard: " + e.getMessage());
e.printStackTrace();
}
}
Expand All @@ -75,7 +75,7 @@ public void onRenamed(Item job, String oldName, String newName) {
String jsonBody = getJsonReqBody(new ItemRename(oldName, newName, itemType));
syncItemListToQD(jsonBody, Constants.QualityDashboardAPI.getItemCrudEndpoint(), "PUT");
} catch(Exception e) {
LOGGER.info("Error syncing item rename to Quality Dashboard: " + e.getMessage());
LOGGER.warning("Error syncing item rename to Quality Dashboard: " + e.getMessage());
e.printStackTrace();
}
}
Expand All @@ -92,7 +92,7 @@ private Response syncItemListToQD(String jsonBody, String url, String typeOfRequ
QualityDashboardAPIUtil apiUtil = new QualityDashboardAPIUtil();
BrowserStackCredentials browserStackCredentials = QualityDashboardUtil.getBrowserStackCreds();
if(browserStackCredentials == null) {
LOGGER.info("BrowserStack credentials not found. Please ensure they are configured correctly.");
LOGGER.warning("BrowserStack credentials not found. Please ensure they are configured correctly.");
return null;
}
if(typeOfRequest.equals("PUT")) {
Expand Down
8 changes: 2 additions & 6 deletions ...om/browserstack/automate/ci/jenkins/qualityDashboard/QualityDashboardPipelineTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void onCompleted(Run<?, ?> run, TaskListener listener) {
}
}
else {
LOGGER.info("BrowserStack credentials not found. Please ensure they are configured correctly.");
LOGGER.warning("BrowserStack credentials not found. Please ensure they are configured correctly.");
}
}

Expand Down Expand Up @@ -133,7 +133,7 @@ private void sendBuildDataToQD(Run<?, ?> run, Result overallResult, String final
rootUpstreamProject = UpstreamPipelineResolver.resolveRootUpstreamProject(run, browserStackCredentials);
immediateParentProject = UpstreamPipelineResolver.resolveImmediateUpstreamProjectForQEI(run, browserStackCredentials);
} catch (Exception e) {
LOGGER.info("Error resolving upstream project for jobName: " + jobName + " and buildNumber: " + buildNumber + ". Exception: " + e.getMessage());
LOGGER.warning("Error resolving upstream project for jobName: " + jobName + " and buildNumber: " + buildNumber + ". Exception: " + e.getMessage());
e.printStackTrace();
}
Timestamp endTime = new Timestamp(endTimeInMillis);
Expand Down Expand Up @@ -191,12 +191,8 @@ private boolean isQDEnabled(BrowserStackCredentials browserStackCredentials) thr
// Check if we have a valid cached value
Boolean cachedResult = QDEnabledCache.getCachedValue();
if (cachedResult != null) {
LOGGER.info("Using cached QD enabled status: " + cachedResult);
return cachedResult;
}

// Cache expired or not set, make API call
LOGGER.info("QD enabled status cache expired or not set, making API call");
Response response = apiUtil.makeGetRequestToQd(Constants.QualityDashboardAPI.getIsQdEnabledEndpoint(), browserStackCredentials);
boolean isEnabled = false;

Expand Down