Raise default permissions of JUnit5JenkinsConfiguredWithCodeRule#2637
Merged
timja merged 1 commit intojenkinsci:masterfrom Feb 4, 2025
strangelookingnerd:junit5_user_permission
Merged
Raise default permissions of JUnit5JenkinsConfiguredWithCodeRule#2637timja merged 1 commit intojenkinsci:masterfrom strangelookingnerd:junit5_user_permission
JUnit5JenkinsConfiguredWithCodeRule#2637timja merged 1 commit intojenkinsci:masterfrom
strangelookingnerd:junit5_user_permission
Conversation
This was referenced Feb 4, 2025
timja
reviewed
Feb 4, 2025
.../java/io/jenkins/plugins/casc/junit/jupiter/JenkinsConfiguredWithCodeRulePermissionTest.java
Show resolved
Hide resolved
timja
reviewed
Feb 4, 2025
.../java/io/jenkins/plugins/casc/junit/jupiter/JenkinsConfiguredWithCodeRulePermissionTest.java
Show resolved
Hide resolved
timja
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same issue / solution as in jenkinsci/jenkins-test-harness#901 / jenkinsci/jenkins-test-harness#910
This PR raises the default permissions of
JUnit5JenkinsConfiguredWithCodeRuleto align with their JUnit4 counterparts.Added
io.jenkins.plugins.casc.junit.jupiter.JenkinsConfiguredWithCodeRulePermissionTestto validate the behavior.Required for jenkinsci/role-strategy-plugin#389 and #2634
Your checklist for this pull request