Skip to content

Jackson 3 update #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonesbusy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Jackson 3 update #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@
<artifactId>workflow-step-api</artifactId>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>jackson2-api</artifactId>
<groupId>io.jenkins.plugins</groupId>
<artifactId>jackson3-api</artifactId>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
Expand Down
8 changes: 4 additions & 4 deletions plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/CoverageViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
import org.apache.commons.lang3.Strings;
import org.apache.commons.lang3.exception.ExceptionUtils;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.ObjectMapper;
import tools.jackson.core.type.TypeReference;
import tools.jackson.databind.ObjectMapper;

import edu.hm.hafner.coverage.Coverage;
import edu.hm.hafner.coverage.FileNode;
Expand Down Expand Up @@ -35,6 +34,7 @@
import org.kohsuke.stapler.StaplerRequest2;
import org.kohsuke.stapler.StaplerResponse2;
import org.kohsuke.stapler.bind.JavaScriptMethod;
import tools.jackson.core.JacksonException;
import hudson.model.Api;
import hudson.model.ModelObject;
import hudson.model.Run;
Expand Down Expand Up @@ -240,7 +240,7 @@
Map<String, String> colorMapping = mapper.readValue(json, new ColorMappingType());
return ColorProviderFactory.createColorProvider(colorMapping);
}
catch (JsonProcessingException e) {
catch (JacksonException e) {

Check warning on line 243 in plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/CoverageViewModel.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 243 is not covered by tests
return ColorProviderFactory.createDefaultColorProvider();
}
}
Expand Down
8 changes: 4 additions & 4 deletions plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/TrendChartFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.jenkins.plugins.coverage.metrics.steps;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ObjectNode;
import tools.jackson.databind.ObjectMapper;
import tools.jackson.databind.node.ObjectNode;
import tools.jackson.core.JacksonException;

import edu.hm.hafner.coverage.Metric;
import edu.hm.hafner.coverage.Value;
Expand Down Expand Up @@ -80,7 +80,7 @@ Set<Metric> getVisibleMetrics(final String configuration) {
.collect(Collectors.toSet());
}
}
catch (JsonProcessingException | ClassCastException | IllegalArgumentException ignored) {
catch (JacksonException | ClassCastException | IllegalArgumentException ignored) {
// ignore and return default values
}

Expand Down
Loading