Skip to content

Optimise new credentials dialog#1016

Merged
timja merged 2 commits intojenkinsci:masterfrom
timja:optimise-dialog
Feb 13, 2026
Merged

Optimise new credentials dialog#1016
timja merged 2 commits intojenkinsci:masterfrom
timja:optimise-dialog

Conversation

@timja
Copy link
Member

@timja timja commented Feb 12, 2026

Optimises the simple case where someone only has one domain so they don't need to click global for no reason

Fixes #1015

If I have multiple domains:
image

If I delete the domain then click on Add credentials the dialog pops straight up:

image

Testing done

Manually tested with single domain and multiple domain and added automated regression tests

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja timja requested a review from a team as a code owner February 12, 2026 22:36
@timja timja requested a review from janfaracik February 12, 2026 22:37
@janfaracik
Copy link
Member

Tested and working as expected - looks good to me!

@timja timja merged commit 375944c into jenkinsci:master Feb 13, 2026
19 checks passed
@timja timja deleted the optimise-dialog branch February 13, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip dropdown when only one domain on New credentials button

2 participants