Skip to content

fix: Create credentials in folder #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 1 commit into from
Feb 17, 2026
Merged

fix: Create credentials in folder #1019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/cloudbees/plugins/credentials/CredentialsStoreAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@
}
// Validate the relative path as a security hardening
// There is no known attack vector here, but just in case as it does control what the form action is.
if (!relativePath.startsWith("/")) {
if (!(relativePath.startsWith("/") || relativePath.startsWith("../"))) {

Check warning on line 589 in src/main/java/com/cloudbees/plugins/credentials/CredentialsStoreAction.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 589 is only partially covered, 3 branches are missing
return null;
}
// Prevent protocol-relative URLs
Expand Down
Loading