Skip to content

Add jdk.net module for Java 25#1127

Closed
jonesbusy wants to merge 1 commit intojenkinsci:masterfrom
jonesbusy:feature/jlink-net-module
Closed

Add jdk.net module for Java 25#1127
jonesbusy wants to merge 1 commit intojenkinsci:masterfrom
jonesbusy:feature/jlink-net-module

Conversation

@jonesbusy
Copy link
Copy Markdown
Contributor

Add jdk.net module for Java 25

I cannot confirm it will fix one of the issue I discovered running Jenkins on Java 25

[16:25:10.392+01:00] - java.lang.ExceptionInInitializerError: Exception java.lang.NoClassDefFoundError: jdk/net/Sockets [in thread "samples-ci-dotnet-core-main-225-sxrcq-djzx4-w70wq [#11] for JNLP4-connect connection to elca-jenkins-agent/172.30.70.87:50000 id=2054"]
[16:25:10.392+01:00] - 	at PluginClassLoader for apache-httpcomponents-client-5-api//org.apache.hc.client5.http.impl.io.DefaultHttpClientConnectionOperator.<clinit>(DefaultHttpClientConnectionOperator.java:87)

Testing done

None. I cannot confirm it will resolve the issue.

But I will certainly test in on my test environment and iterate if needed

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@lemeurherve
Copy link
Copy Markdown
Member

lemeurherve commented Jan 14, 2026

Noting #1124 (comment)


Testing done

None. I cannot confirm it will resolve the issue.

But I will certainly test in on my test environment and iterate if needed

Can you (at least) run make test on a local image, and test it in your environment (nice to have) please?

Having an dedicated additional test in ./tests/ would be nice to have too.

We can help you if you need, just let us know 🙂

@lemeurherve
Copy link
Copy Markdown
Member

the issue I discovered running Jenkins on Java 25

@jonesbusy could you mind open a dedicated issue describing the error you found please?

That would be helpful as reference for this PR and #1124, and easier for you to add details if you're the author of that issue.

@lemeurherve
Copy link
Copy Markdown
Member

Suggesting to wait for #1128 (if accepted) to include this change 🙂

@jonesbusy jonesbusy marked this pull request as draft January 20, 2026 13:42
@lemeurherve
Copy link
Copy Markdown
Member

@jonesbusy FYI I'll resume the work on #1132 and #1128 soon so you can progress on this.


Eventually related: jenkinsci/apache-httpcomponents-client-5-api-plugin#119

Copy link
Copy Markdown
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some tech debt from #201. TBH I am not sure how this was ever safe. What is some plugin sends a ControllerToAgentCallable which requires one of the Java modules that was not bundled?

@lemeurherve
Copy link
Copy Markdown
Member

lemeurherve commented Feb 15, 2026

Cf #1132 (comment),

Closing in favor or "[an incoming] system to provide early testers an image[, to] be discussed and implemented"

@jonesbusy jonesbusy deleted the feature/jlink-net-module branch February 16, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants