-
-
Notifications
You must be signed in to change notification settings - Fork 180
feat: add JDK25 Linux images #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gounthar
wants to merge
4
commits into
jenkinsci:master
Choose a base branch
from
gounthar:jdk25-preview
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−30
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fcb7185
feat: add JDK25 preview support for Linux images
gounthar 4000a02
feat: enhance JDK 25 support by allowing custom JLINK_MODULES for ima…
gounthar 349f751
Merge branch 'master' into jdk25-preview
gounthar 3c5c034
Apply suggestions from code review
gounthar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -43,19 +43,22 @@ RUN apk add --no-cache \ | |||||||||||
|
||||||||||||
ENV PATH="/opt/jdk-${JAVA_VERSION}/bin:${PATH}" | ||||||||||||
|
||||||||||||
ARG JLINK_MODULES | ||||||||||||
|
||||||||||||
RUN case "$(jlink --version 2>&1)" in \ | ||||||||||||
"17."*) set -- "--compress=2" ;; \ | ||||||||||||
# the compression argument is different for JDK21 | ||||||||||||
"21."*) set -- "--compress=zip-6" ;; \ | ||||||||||||
*) echo "ERROR: unmanaged jlink version pattern" && exit 1 ;; \ | ||||||||||||
esac; \ | ||||||||||||
jlink \ | ||||||||||||
--strip-java-debug-attributes \ | ||||||||||||
"$1" \ | ||||||||||||
--add-modules ALL-MODULE-PATH \ | ||||||||||||
--no-man-pages \ | ||||||||||||
--no-header-files \ | ||||||||||||
--output /javaruntime | ||||||||||||
"17."*) set -- "--compress=2" --add-modules ALL-MODULE-PATH ;; \ | ||||||||||||
"21."*) set -- "--compress=zip-6" --add-modules ALL-MODULE-PATH ;; \ | ||||||||||||
# JDK 25 switches to a minimal module set for smaller images. Override with JLINK_MODULES to restore broader compatibility if needed. | ||||||||||||
"25"*) mod_list="${JLINK_MODULES:-java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec}"; \ | ||||||||||||
set -- "--compress=zip-6" --add-modules "$mod_list" ;; \ | ||||||||||||
Comment on lines
+49
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Let's keep in simple for now like what's in the docker-agent which already has JDK25 images. |
||||||||||||
*) echo "ERROR: unmanaged jlink version pattern" && exit 1 ;; \ | ||||||||||||
esac; \ | ||||||||||||
jlink \ | ||||||||||||
--strip-java-debug-attributes \ | ||||||||||||
"$@" \ | ||||||||||||
--no-man-pages \ | ||||||||||||
--no-header-files \ | ||||||||||||
--output /javaruntime | ||||||||||||
|
||||||||||||
FROM alpine:"${ALPINE_TAG}" AS build | ||||||||||||
|
||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -42,22 +42,25 @@ RUN set -x; apt-get update \ | |||||||||||
|
||||||||||||
ENV PATH="/opt/jdk-${JAVA_VERSION}/bin:${PATH}" | ||||||||||||
|
||||||||||||
ARG JLINK_MODULES | ||||||||||||
|
||||||||||||
gounthar marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||
# Generate smaller java runtime without unneeded files | ||||||||||||
# for now we include the full module path to maintain compatibility | ||||||||||||
# while still saving space (approx 200mb from the full distribution) | ||||||||||||
RUN case "$(jlink --version 2>&1)" in \ | ||||||||||||
"17."*) set -- "--compress=2" ;; \ | ||||||||||||
# the compression argument is different for JDK21 | ||||||||||||
"21."*) set -- "--compress=zip-6" ;; \ | ||||||||||||
*) echo "ERROR: unmanaged jlink version pattern" && exit 1 ;; \ | ||||||||||||
esac; \ | ||||||||||||
jlink \ | ||||||||||||
--strip-java-debug-attributes \ | ||||||||||||
"$1" \ | ||||||||||||
--add-modules ALL-MODULE-PATH \ | ||||||||||||
--no-man-pages \ | ||||||||||||
--no-header-files \ | ||||||||||||
--output /javaruntime | ||||||||||||
"17."*) set -- "--compress=2" --add-modules ALL-MODULE-PATH ;; \ | ||||||||||||
"21."*) set -- "--compress=zip-6" --add-modules ALL-MODULE-PATH ;; \ | ||||||||||||
# JDK 25 switches to a minimal module set for smaller images. Override with JLINK_MODULES to restore broader compatibility if needed. | ||||||||||||
"25"*) mod_list="${JLINK_MODULES:-java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec}"; \ | ||||||||||||
set -- "--compress=zip-6" --add-modules "$mod_list" ;; \ | ||||||||||||
Comment on lines
+51
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
ditto |
||||||||||||
*) echo "ERROR: unmanaged jlink version pattern" && exit 1 ;; \ | ||||||||||||
esac; \ | ||||||||||||
jlink \ | ||||||||||||
--strip-java-debug-attributes \ | ||||||||||||
"$@" \ | ||||||||||||
--no-man-pages \ | ||||||||||||
--no-header-files \ | ||||||||||||
--output /javaruntime | ||||||||||||
|
||||||||||||
FROM debian:"${DEBIAN_RELEASE}" | ||||||||||||
|
||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.