Improve SMTP host and port validation with descriptor checks and unit…#1471
Open
wisekiran wants to merge 1 commit intojenkinsci:mainfrom
Open
Improve SMTP host and port validation with descriptor checks and unit…#1471wisekiran wants to merge 1 commit intojenkinsci:mainfrom
wisekiran wants to merge 1 commit intojenkinsci:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves validation for SMTP host and port fields in the
MailAccountdescriptor.Changes include:
This change improves configuration UX and adds defensive validation without altering existing email sending behavior.
Testing done
Automated testing
mvn clean installcompletes successfully.Manual testing
mvn hpi:runUI Before
UI After
Submitter checklist