Conversation
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| <workflow.version>1.4</workflow.version> | ||
| <jenkins.version>2.7</jenkins.version> | ||
| <jenkins.version>2.230</jenkins.version> |
There was a problem hiding this comment.
This means that the plugin won't be compatible with older Jenkins (namely no current LTS will be able to use it). Probably you'd rather support several LTS.
I personnaly would choose something like 2.190 or 2.176 but I don't have a lot of experience to choose this others might have better advices. You can also have a look to https://stats.jenkins.io/pluginversions/ghprb.html to decide.
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>scm-api</artifactId> | ||
| <version>2.1.0</version> | ||
| <version>2.6.3</version> |
There was a problem hiding this comment.
Relying on the BOM (see doc https://jenkins.io/doc/developer/plugin-development/dependency-management/) would avoid manually setting up versions for the plugin dependencies.
samrocketman
left a comment
samrocketman
left a comment
There was a problem hiding this comment.
Per @PierreBtz recommendations
- Rely on Jenkins bom.
- Rely on a known LTS version of Jenkins for parent pom.
Although I've been largely inactive on this project for the past two years I am kind of picking it back up a little bit in my spare time. I would be willing to merge something like this.
Hi, Sorry for so much delay, I was in vacation. Thank you for yours comments, I will take care of them. |
3 participants
Hi everyone,
The goal of this PR is to update most of the dependencies which are a bit old.
I have also switch to Java 8.
I have more modifications to come, dedicated to already existing issues.
I will take care of your comments.
Have a nice review.