Prevent triggering builds on closed PRs#866
Open
JackPGreen wants to merge 1 commit intojenkinsci:masterfrom
Open
Prevent triggering builds on closed PRs#866JackPGreen wants to merge 1 commit intojenkinsci:masterfrom
JackPGreen wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Skips all kind of event triggers for closed PRs, rather than just for comments as per jenkinsci#54. I've not added a test to cover this, as there's no existing test coverage for `pull_request` events in `org.jenkinsci.plugins.ghprb.GhprbRootActionTest`, nor is there any example payloads in `org.jenkinsci.plugins.ghprb.GhprbTestUtil`. Fixes: jenkinsci#865
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skips all kind of event triggers for closed PRs, rather than just for comments as per #54.
Fixes: #865
Testing done
I've not added a test to cover this, as there's no existing test coverage for
pull_requestevents inorg.jenkinsci.plugins.ghprb.GhprbRootActionTest, nor is there any example payloads inorg.jenkinsci.plugins.ghprb.GhprbTestUtil.I've tested on a private Jenkins instance.
Submitter checklist