Skip to content

HttpTransport ≠ TransportHttp #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

HttpTransport ≠ TransportHttp #1302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb1a66f
HttpTransport ≠ TransportHttp
daniel-beck Jun 25, 2025
0a55f4d
instanceof pattern matching
daniel-beck Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/main/java/org/jenkinsci/plugins/gitclient/JGitAPIImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
import org.eclipse.jgit.submodule.SubmoduleWalk;
import org.eclipse.jgit.transport.CredentialsProvider;
import org.eclipse.jgit.transport.FetchConnection;
import org.eclipse.jgit.transport.HttpTransport;
import org.eclipse.jgit.transport.PushResult;
import org.eclipse.jgit.transport.RefSpec;
import org.eclipse.jgit.transport.RemoteConfig;
Expand Down Expand Up @@ -993,9 +992,8 @@ private TransportConfigCallback getTransportConfigCallback() {
if (transport instanceof SshTransport sshTransport) {
sshTransport.setSshSessionFactory(buildSshdSessionFactory(this.hostKeyVerifierFactory));
}
if (transport instanceof HttpTransport) {
((TransportHttp) transport)
.setHttpConnectionFactory(new PreemptiveAuthHttpClientConnectionFactory(getProvider()));
if (transport instanceof TransportHttp transportHttp) {
transportHttp.setHttpConnectionFactory(new PreemptiveAuthHttpClientConnectionFactory(getProvider()));
}
};
}
Expand All @@ -1004,8 +1002,8 @@ private void decorateTransport(Transport tn) {
if (tn instanceof SshTransport transport) {
transport.setSshSessionFactory(buildSshdSessionFactory(getHostKeyFactory()));
}
if (tn instanceof HttpTransport) {
((TransportHttp) tn).setHttpConnectionFactory(new PreemptiveAuthHttpClientConnectionFactory(getProvider()));
if (tn instanceof TransportHttp transportHttp) {
transportHttp.setHttpConnectionFactory(new PreemptiveAuthHttpClientConnectionFactory(getProvider()));
}
}

Expand Down