Skip to content

Conversation

MonthyCurious
Copy link

Fixes for the JENKINS-75860 Jira issue

Testing done

passed mvn clean verify
executed mvn spotless:apply

@MonthyCurious MonthyCurious requested a review from a team as a code owner July 7, 2025 11:46
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

Needs tests that show the problem before the change and confirm the problem is fixed by the change. The current test that invokes setSubmoduleUrl then calls getSubmoduleUrl to confirm that the set happened.

This change is moving the location that is written and read. That is good, because the test passes, but the test does not confirm that the rest of the code is functional with that change.

@MonthyCurious
Copy link
Author

I added more info to the Jira.

Since the error is only encountered when .git/config and .gitmodules are out of sync (as are mine), I think that unifying the git commands (either use -f .gitmodules consistently everywhere or nowhere) would be good but nothing pressing.

I know the problem and can fix my git files. Please handle this PR and the associated Jira as you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants