Migrate tests to JUnit5#1324
Closed
strangelookingnerd wants to merge 15 commits intojenkinsci:masterfrom
strangelookingnerd:migrate_to_junit5
Closed
Migrate tests to JUnit5#1324strangelookingnerd wants to merge 15 commits intojenkinsci:masterfrom strangelookingnerd:migrate_to_junit5
strangelookingnerd wants to merge 15 commits intojenkinsci:masterfrom
strangelookingnerd:migrate_to_junit5
Conversation
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup
MarkEWaite
reviewed
Aug 23, 2025
Contributor
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
Deeper review will be needed in the future, but wanted to share one comment from the start of the review.
Include a wider range of small repositories in order to be more likely to detect shifts in the turning point where command line git performs better than JGit. Current data shows that JGit is faster than command line git for repositories up to 8 MB. Command line git is dramatically faster than JGit for the 450 MB repository that is the largest repository used in the test.
Unreliable due to GitHub message
Spotless
MarkEWaite
reviewed
Sep 8, 2025
Contributor
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
Thanks again for this great effort. I'll review further when I return from vacation in a week
src/test/java/org/jenkinsci/plugins/gitclient/verifier/KnownHostsTestUtil.java
Show resolved
Hide resolved
src/test/java/org/jenkinsci/plugins/gitclient/verifier/KnownHostsTestUtil.java
Show resolved
Hide resolved
Contributor
|
I've resolved the conflict and pushed the resolution to my fork of the repository at: |
Contributor
|
Thanks very much! I resolved the conflict and squash merged it as:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.
Submitter checklist