Merge pull request #1104 from jenkinsci/dependabot/maven/org.jvnet.hudson.plugins-analysis-pom-11.2867.v81ec3848d647

uhafner · web-flow · commit 9d6ab58f1471 · 2025-11-05T22:04:39.000+01:00
Bump org.jvnet.hudson.plugins:analysis-pom from 11.2852.v88a_36fe3230d to 11.2867.v81ec3848d647
diff --git a/.github/quality-gates.json b/.github/quality-gates.json
@@ -13,7 +13,7 @@
     },
     {
       "metric": "branch",
-      "threshold": 80.0,
+      "threshold": 75.0,
       "criticality": "UNSTABLE"
     },
     {
diff --git a/plugin/pom.xml b/plugin/pom.xml
@@ -45,18 +45,6 @@
   </properties>
 
   <dependencies>
-    <!-- Project Dependencies -->
-    <dependency>
-      <groupId>org.eclipse.collections</groupId>
-      <artifactId>eclipse-collections-api</artifactId>
-      <version>${eclipse-collections.version}</version>
-    </dependency>
-    <dependency>
-      <groupId>org.eclipse.collections</groupId>
-      <artifactId>eclipse-collections</artifactId>
-      <version>${eclipse-collections.version}</version>
-    </dependency>
-
     <!-- Jenkins Plugin Dependencies -->
     <dependency>
       <groupId>org.jenkins-ci.plugins</groupId>
diff --git a/plugin/src/main/java/io/jenkins/plugins/forensics/git/blame/GitBlamer.java b/plugin/src/main/java/io/jenkins/plugins/forensics/git/blame/GitBlamer.java
@@ -51,6 +51,7 @@ class GitBlamer extends Blamer {
     static final String NO_HEAD_ERROR = "Could not retrieve HEAD commit, aborting";
     static final String BLAME_ERROR = "Computing blame information failed with an exception:";
 
+    @SuppressWarnings("serial")
     private final GitClient git;
     private final String gitCommit;
 
diff --git a/plugin/src/main/java/io/jenkins/plugins/forensics/git/delta/GitDeltaCalculator.java b/plugin/src/main/java/io/jenkins/plugins/forensics/git/delta/GitDeltaCalculator.java
@@ -32,6 +32,7 @@ public class GitDeltaCalculator extends DeltaCalculator {
     static final String DELTA_ERROR = "Computing delta information failed with an exception:";
     static final String EMPTY_COMMIT_ERROR = "Calculating the Git code delta is not possible due to an unknown commit ID";
 
+    @SuppressWarnings("serial")
     private final GitClient git;
     private final String scmKey;
 
@@ -51,6 +52,7 @@ public GitDeltaCalculator(final GitClient git, final String scmKey) {
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Optional<Delta> calculateDelta(final Run<?, ?> build, final Run<?, ?> referenceBuild,
             final String scmKeyFilter, final FilteredLog log) {
         var scm = StringUtils.defaultIfEmpty(scmKeyFilter, scmKey);
diff --git a/plugin/src/main/java/io/jenkins/plugins/forensics/git/miner/CommitStatisticsStep.java b/plugin/src/main/java/io/jenkins/plugins/forensics/git/miner/CommitStatisticsStep.java
@@ -225,6 +225,7 @@ public String getDisplayName() {
         }
 
         @Override
+        @SuppressWarnings("rawtypes")
         public boolean isApplicable(final Class<? extends AbstractProject> jobType) {
             return true;
         }
diff --git a/plugin/src/main/java/io/jenkins/plugins/forensics/git/miner/GitRepositoryMiner.java b/plugin/src/main/java/io/jenkins/plugins/forensics/git/miner/GitRepositoryMiner.java
@@ -31,6 +31,7 @@ public class GitRepositoryMiner extends RepositoryMiner {
     @Serial
     private static final long serialVersionUID = 1157958118716013983L;
 
+    @SuppressWarnings("serial")
     private final GitClient gitClient;
 
     GitRepositoryMiner(final GitClient gitClient) {
diff --git a/plugin/src/main/java/io/jenkins/plugins/forensics/git/reference/BuildCommits.java b/plugin/src/main/java/io/jenkins/plugins/forensics/git/reference/BuildCommits.java
@@ -23,7 +23,8 @@ class BuildCommits implements Serializable {
 
     private final String previousBuildCommit;
 
-    private final List<String> commits = new ArrayList<>();
+    @SuppressWarnings("PMD.LooseCoupling")
+    private final ArrayList<String> commits = new ArrayList<>();
 
     private ObjectId head = ObjectId.zeroId();
     private ObjectId target = ObjectId.zeroId();
diff --git a/plugin/src/main/java/io/jenkins/plugins/forensics/git/reference/GitCommitsRecord.java b/plugin/src/main/java/io/jenkins/plugins/forensics/git/reference/GitCommitsRecord.java
@@ -1,6 +1,6 @@
 package io.jenkins.plugins.forensics.git.reference;
 
-import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.eclipse.jgit.lib.ObjectId;
 
 import edu.hm.hafner.util.FilteredLog;
@@ -42,7 +42,7 @@ public class GitCommitsRecord implements RunAction2, Serializable {
      */
     public static Optional<GitCommitsRecord> findRecordForScm(final Run<?, ?> build, final String scmKey) {
         return build.getActions(GitCommitsRecord.class).stream()
-                .filter(record -> StringUtils.containsIgnoreCase(record.getScmKey(), scmKey))
+                .filter(record -> Strings.CI.contains(record.getScmKey(), scmKey))
                 .findAny();
     }
 
@@ -58,9 +58,12 @@ public static Optional<GitCommitsRecord> findRecordForScm(final Run<?, ?> build,
     private final RecordingType recordingType;
     private final String latestCommitLink;
     private final String targetParentCommit;
-    private final List<String> commits;
-    private final List<String> errorMessages;
-    private final List<String> infoMessages;
+    @SuppressWarnings("PMD.LooseCoupling")
+    private final ArrayList<String> commits;
+    @SuppressWarnings("PMD.LooseCoupling")
+    private final ArrayList<String> errorMessages;
+    @SuppressWarnings("PMD.LooseCoupling")
+    private final ArrayList<String> infoMessages;
 
     /** Determines if this record is the starting point or an incremental record that is based on the previous record. */
     enum RecordingType {
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>org.jvnet.hudson.plugins</groupId>
     <artifactId>analysis-pom</artifactId>
-    <version>11.2852.v88a_36fe3230d</version>
+    <version>11.2867.v81ec3848d647</version>
     <relativePath />
   </parent>
 
diff --git a/ui-tests/src/main/java/io/jenkins/plugins/forensics/git/DetailsTable.java b/ui-tests/src/main/java/io/jenkins/plugins/forensics/git/DetailsTable.java
@@ -1,20 +1,21 @@
 package io.jenkins.plugins.forensics.git;
 
+import org.openqa.selenium.By;
+import org.openqa.selenium.Keys;
+import org.openqa.selenium.WebElement;
+
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
+import java.util.Locale;
 import java.util.stream.Collectors;
 
-import org.openqa.selenium.By;
-import org.openqa.selenium.Keys;
-import org.openqa.selenium.WebElement;
-
 /**
  * Page object for the details-table of the forensics view.
  *
  * @author Mitja Oldenbourg
  */
-public class DetailsTable {
+public final class DetailsTable {
     static final String FILE_NAME = "File";
     static final String AUTHORS = "#Authors";
     static final String COMMITS = "#Commits";
@@ -165,6 +166,6 @@ private void updateTableRows() {
     }
 
     private WebElement getHeaderAsWebElement(final int option) {
-        return page.findElement(By.xpath(String.format(".//thead/tr/th[%d]", option)));
+        return page.findElement(By.xpath(String.format(Locale.ENGLISH, ".//thead/tr/th[%d]", option)));
     }
 }
diff --git a/ui-tests/src/main/java/io/jenkins/plugins/forensics/git/ScmForensics.java b/ui-tests/src/main/java/io/jenkins/plugins/forensics/git/ScmForensics.java
@@ -1,12 +1,12 @@
 package io.jenkins.plugins.forensics.git;
 
-import java.net.URL;
-
 import org.apache.commons.lang3.StringUtils;
 import org.openqa.selenium.By;
 
 import com.google.inject.Injector;
 
+import java.net.URL;
+
 import org.jenkinsci.test.acceptance.po.Build;
 import org.jenkinsci.test.acceptance.po.PageObject;
 
@@ -52,7 +52,7 @@ public ScmForensics(final Injector injector, final URL url, final String id) {
     public int getTotal() {
         String total = find(By.id("forensics_info")).getText();
 
-        return Integer.parseInt(StringUtils.substringAfter(total, "of ").split(" ")[0]);
+        return Integer.parseInt(StringUtils.substringAfter(total, "of ").split(" ", 0)[0]);
     }
 }
 
diff --git a/ui-tests/src/main/java/io/jenkins/plugins/forensics/git/ScrollerUtil.java b/ui-tests/src/main/java/io/jenkins/plugins/forensics/git/ScrollerUtil.java
@@ -19,8 +19,8 @@ public final class ScrollerUtil {
      */
     public static void hideScrollerTabBar(final WebDriver driver) {
         WebElement element = driver.findElement(By.xpath("//div[contains(@class, 'jenkins-config-widgets')]"));
-        if (driver instanceof JavascriptExecutor) {
-            ((JavascriptExecutor) driver).executeScript("arguments[0].style.visibility='hidden'", element);
+        if (driver instanceof JavascriptExecutor executor) {
+            executor.executeScript("arguments[0].style.visibility='hidden'", element);
         }
     }
 
diff --git a/ui-tests/src/main/java/io/jenkins/plugins/forensics/git/Summary.java b/ui-tests/src/main/java/io/jenkins/plugins/forensics/git/Summary.java
@@ -1,13 +1,13 @@
 package io.jenkins.plugins.forensics.git;
 
-import java.util.List;
-import java.util.regex.Pattern;
-import java.util.stream.Collectors;
-
 import org.apache.commons.lang3.StringUtils;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 
+import java.util.List;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+
 import org.jenkinsci.test.acceptance.po.Build;
 import org.jenkinsci.test.acceptance.po.PageObject;
 
@@ -34,7 +34,7 @@ public class Summary extends PageObject {
      * @param id
      *         the type of the result page (e.g. simian, checkstyle, cpd, etc.)
      */
-    @SuppressWarnings("PMD.ConstructorCallsOverridableMethod")
+    @SuppressWarnings({"PMD.ConstructorCallsOverridableMethod", "this-escape"})
     public Summary(final Build parent, final String id) {
         super(parent, parent.url(id));
 
diff --git a/ui-tests/src/test/java/io/jenkins/plugins/forensics/git/SmokeTests.java b/ui-tests/src/test/java/io/jenkins/plugins/forensics/git/SmokeTests.java
@@ -1,7 +1,5 @@
 package io.jenkins.plugins.forensics.git;
 
-import java.util.List;
-
 import org.junit.Test;
 
 import org.jenkinsci.test.acceptance.junit.AbstractJUnitTest;
@@ -30,8 +28,8 @@ public class SmokeTests extends AbstractJUnitTest {
      */
     @Test
     public void shouldMineGitHubRepository() {
-        WorkflowJob job = createJob();
-        Build build = buildSuccessfully(job);
+        var job = createJob();
+        var build = buildSuccessfully(job);
 
         assertThat(build.getConsole()).contains(
                 "Found 428 commits",
@@ -40,14 +38,14 @@ public void shouldMineGitHubRepository() {
 
         build.open();
 
-        Summary commitStatistics = new Summary(build, "commits-of-" + SCM_HASH);
+        var commitStatistics = new Summary(build, "commits-of-" + SCM_HASH);
         assertThat(commitStatistics).hasTitle("SCM: " + SCM_KEY);
         assertThat(commitStatistics).hasDetails("Initial recording of 200 commits", "Latest commit: 28af63d");
         assertThat(commitStatistics.openLinkByText("28af63d")).isEqualTo("https://github.com/jenkinsci/git-forensics-plugin/commit/28af63def44286729e3b19b03464d100fd1d0587");
 
         build.open();
 
-        Summary scmForensics = new Summary(build, "scm-forensics-of-" + SCM_HASH);
+        var scmForensics = new Summary(build, "scm-forensics-of-" + SCM_HASH);
         assertThat(scmForensics).hasTitle("SCM Forensics: " + SCM_KEY);
         assertThat(scmForensics).hasDetails("51 repository files (total lines of code: 6066, total churn: 16966)",
                 "New commits: 402 (from 4 authors in 131 files)",
@@ -57,11 +55,11 @@ public void shouldMineGitHubRepository() {
 
         // TODO: navigate from summary
 
-        ScmForensics forensicsDetails = new ScmForensics(build, "forensics");
+        var forensicsDetails = new ScmForensics(build, "forensics");
         forensicsDetails.open();
         assertThat(forensicsDetails.getTotal()).isEqualTo(51);
 
-        DetailsTable detailsTable = new DetailsTable(forensicsDetails);
+        var detailsTable = new DetailsTable(forensicsDetails);
         assertTableHeaders(detailsTable);
         assertTableEntriesAndSorting(detailsTable);
         assertSearch(detailsTable);
@@ -89,7 +87,7 @@ private WorkflowJob createJob() {
     private void assertTableHeaders(final DetailsTable detailsTable) {
         assertThat(detailsTable.getHeaderSize()).isEqualTo(7);
 
-        List<String> tableHeaders = detailsTable.getHeaders();
+        var tableHeaders = detailsTable.getHeaders();
         assertThat(tableHeaders.get(0)).isEqualTo(FILE_NAME);
         assertThat(tableHeaders.get(1)).isEqualTo(AUTHORS);
         assertThat(tableHeaders.get(2)).isEqualTo(COMMITS);
@@ -179,7 +177,7 @@ private void assertPagination(final DetailsTable detailsTable) {
 
     private void assertRow(final DetailsTable detailsTable,
             final int rowNum, final String fileName, final int numAuthors, final int numCommits) {
-        DetailsTableRow secondRow = detailsTable.getTableRows().get(rowNum);
+        var secondRow = detailsTable.getTableRows().get(rowNum);
 
         assertThat(secondRow.getFileName()).isEqualTo(fileName);
         assertThat(secondRow.getNumberOfAuthors()).isEqualTo(numAuthors);

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`},`
`14`	`14`	`{`
`15`	`15`	`"metric": "branch",`
`16`		`- "threshold": 80.0,`
	`16`	`+ "threshold": 75.0,`
`17`	`17`	`"criticality": "UNSTABLE"`
`18`	`18`	`},`
`19`	`19`	`{`
Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,7 @@ public String getDisplayName() {`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`@Override`
	`228`	`+ @SuppressWarnings("rawtypes")`
`228`	`229`	`public boolean isApplicable(final Class<? extends AbstractProject> jobType) {`
`229`	`230`	`return true;`
`230`	`231`	`}`