Revert b89550f51a7e996779192e126a3d487f4e0a4bcb (re-enable Windows encoding test) #146
Closed
dduportal wants to merge 6 commits intojenkinsci:masterfrom
Closed
Revert b89550f51a7e996779192e126a3d487f4e0a4bcb (re-enable Windows encoding test) #146dduportal wants to merge 6 commits intojenkinsci:masterfrom
dduportal wants to merge 6 commits intojenkinsci:masterfrom
Conversation
This change allows the Jenkins Infra team to retry Windows builds and test the encoding settings. Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Save a little time evaluating changes
Contributor
|
I reduced the number of tests to run on this branch in order to reduce the cycle time. No need to run more tests than necessary. Commit d7adf37 I left it running on both Windows and Linux because I recall that there were some specific conditions that need at least one Linux build. |
Member
|
#145 (comment) FWIW |
Contributor
|
Will fix the test, since it should not be charset dependent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. jenkins-infra/helpdesk#4568 (comment)
This change allows the Jenkins Infra team to retry Windows builds and test the encoding settings.
It is a manual revert of b89550f which is hidden inside #145
It must stay in draft until jenkins-infra/helpdesk#4568 is updated.