Skip to content

Migrate tests to JUnit5#147

Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom
strangelookingnerd:migrate_to_junit5
Mar 5, 2025
Merged

Migrate tests to JUnit5#147
MarkEWaite merged 1 commit intojenkinsci:masterfrom
strangelookingnerd:migrate_to_junit5

Conversation

@strangelookingnerd
Copy link
Copy Markdown
Contributor

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations and imports
  • Migrate assertions
  • Remove public visibility for test classes and methods
  • Minor clean up

I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor code cleanup
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner March 4, 2025 13:39
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Mar 5, 2025
Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 5aa1aa8 into jenkinsci:master Mar 5, 2025
17 checks passed
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Mar 23, 2025
Pull request in the repository that will enable CD:

* jenkinsci/git-parameter-plugin#153

Pull requests that will be delivered by the automated release:

* jenkinsci/git-parameter-plugin#151
* jenkinsci/git-parameter-plugin#150
* jenkinsci/git-parameter-plugin#147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Automated test addition or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants