Skip to content

[JENKINS-75462] Use consistent style for configuration filter drop down#151

Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom
ridemountainpig:JENKINS-75462
Mar 21, 2025
Merged

[JENKINS-75462] Use consistent style for configuration filter drop down#151
MarkEWaite merged 1 commit intojenkinsci:masterfrom
ridemountainpig:JENKINS-75462

Conversation

@ridemountainpig
Copy link
Copy Markdown
Contributor

See JENKINS-75462.

Testing done

Before:

CleanShot 2025-03-21 at 14 50 39

After:

CleanShot 2025-03-21 at 14 48 24

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ridemountainpig ridemountainpig requested a review from a team as a code owner March 21, 2025 07:01
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Mar 21, 2025
Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. I verified that the change works well.

Merging.

Any chance you are interested in making the same fix in the page that is shown when the job is run? I am merging this fix and will release it whether or not you are interested in making the other fix. You've shown how the fix can be done very cleanly.

screencapture-mark-pc2-markwaite-net-8080-job-a-freestyle-with-choice-params-build-2025-03-21-05_11_33-edit

@MarkEWaite MarkEWaite merged commit 90e24a5 into jenkinsci:master Mar 21, 2025
17 checks passed
@MarkEWaite MarkEWaite changed the title [JENKINS-75462] Fix filter drop select input is out of style with other components [JENKINS-75462] Use consistent style for configuration filter drop down Mar 21, 2025
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Mar 23, 2025
Pull request in the repository that will enable CD:

* jenkinsci/git-parameter-plugin#153

Pull requests that will be delivered by the automated release:

* jenkinsci/git-parameter-plugin#151
* jenkinsci/git-parameter-plugin#150
* jenkinsci/git-parameter-plugin#147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Incorrect or flawed behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants