Skip to content

jenkins-client-213 - Added ability to get build for job name and number #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

jenkins-client-213 - Added ability to get build for job name and number #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions jenkins-client/src/main/java/com/offbytwo/jenkins/JenkinsServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
import java.util.List;
import java.util.Map;

Expand Down Expand Up @@ -770,6 +771,32 @@ public Build getBuild(QueueItem q) throws IOException {
}
}

/**
* Fetch build basing on jobName and build number
*
* @param jobName
* @param buildNumber
* @return Build object
*
* @throws IOException
* @throws URISyntaxException
*/
public Build getBuild(String jobName, Long buildNumber) throws IOException, URISyntaxException {
try {
String url = new URI(jobName +"/" + buildNumber).toString();
Build build = client.get(url, Build.class);
if(build!=null){
build.setClient(client);
}
return build;
} catch (HttpResponseException e) {
if (e.getStatusCode() == HttpStatus.SC_NOT_FOUND) {
return null;
}
throw e;
}
}

/**
* Rename a job
*
Expand Down
21 changes: 16 additions & 5 deletions jenkins-client/src/test/java/com/offbytwo/jenkins/JenkinsServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,14 @@
import java.util.Map;
import java.util.UUID;

import com.offbytwo.jenkins.model.*;
import org.apache.http.entity.ContentType;
import org.junit.Before;
import org.junit.Test;
import org.mockito.ArgumentCaptor;

import com.google.common.base.Optional;
import com.offbytwo.jenkins.client.JenkinsHttpClient;
import com.offbytwo.jenkins.model.FolderJob;
import com.offbytwo.jenkins.model.Job;
import com.offbytwo.jenkins.model.JobWithDetails;
import com.offbytwo.jenkins.model.MainView;
import com.offbytwo.jenkins.model.View;

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
Expand Down Expand Up @@ -114,6 +110,21 @@ public void testFolderGetJob() throws Exception {
assertEquals(someJob, jobResult);
}

@Test
public void testGetBuild() throws Exception {
// given
BuildWithDetails someBuild = mock(BuildWithDetails.class);

given(client.get(eq("job/1"), eq(Build.class))).willReturn(someBuild);

// when
Build build = server.getBuild("job", 1l);

// then
verify(client).get("job/1", Build.class);
assertEquals(someBuild, build);
}

@Test
public void testFolderGetView() throws Exception {
// given
Expand Down