Skip to content

httpclient didn't release when http validateResponse false. #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2017
Merged

httpclient didn't release when http validateResponse false. #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ target
.project
.settings
test-output
.DS_Store
4 changes: 2 additions & 2 deletions jenkins-client/src/main/java/com/offbytwo/jenkins/client/JenkinsHttpClient.java
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,8 @@ public String post_xml(String path, String xml_data, boolean crumbFlag) throws I
}
HttpResponse response = client.execute(request, localContext);
getJenkinsVersionFromHeader(response);
httpResponseValidator.validateResponse(response);
try {
httpResponseValidator.validateResponse(response);
return IOUtils.toString(response.getEntity().getContent());
} finally {
EntityUtils.consume(response.getEntity());
Expand Down Expand Up @@ -386,8 +386,8 @@ public String post_text(String path, String textData, ContentType contentType, b
}
HttpResponse response = client.execute(request, localContext);
getJenkinsVersionFromHeader(response);
httpResponseValidator.validateResponse(response);
try {
httpResponseValidator.validateResponse(response);
return IOUtils.toString(response.getEntity().getContent());
} finally {
EntityUtils.consume(response.getEntity());
Expand Down