Skip to content

Fixed #282 #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Fixed #282 #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Release 0.3.8 (NOT RELEASED YET)

* [Fixed Issue 282][issue-282]

`NullPointerException` may be thrown if `upstreamUrl` is `null` when
converting cause to `BuildCause` object.

* [Fixed Issue 268][issue-268]

NullPointerException is thrown unless isRunning() is called first.
Expand Down
2 changes: 1 addition & 1 deletion jenkins-client/src/main/java/com/offbytwo/jenkins/model/BuildWithDetails.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ private BuildCause convertToBuildCause(Map<String, Object> cause) {
}

String upstreamUrl = (String) cause.get("upstreamUrl");
if (!Strings.isNullOrEmpty(upstreamProject)) {
if (!Strings.isNullOrEmpty(upstreamUrl)) {
cause_object.setUpstreamUrl(upstreamUrl);
}

Expand Down