Skip to content

Fixed #301 Decoupled JenkinsServer and JenkinsHttpClient #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Fixed #301 Decoupled JenkinsServer and JenkinsHttpClient #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
## Release 0.3.8 (NOT RELEASED YET)


* [Fixed Issue 301][issue-301]

Decoupled JenkinsServer and JenkinsHttpClient by extracting JenkinsHttpClient
methods into public interface so that different implementations can be plugged
into JenkinsServer if required


* [Fixed Issue 298][issue-298]

Added Closeable support to JenkinsServer and JenkinsHttpClient so that
Expand Down
8 changes: 6 additions & 2 deletions jenkins-client/src/main/java/com/offbytwo/jenkins/JenkinsServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Maps;
import com.offbytwo.jenkins.client.JenkinsHttpClient;
import com.offbytwo.jenkins.client.JenkinsHttpConnection;
import com.offbytwo.jenkins.client.util.EncodingUtils;
import com.offbytwo.jenkins.client.util.UrlUtils;
import com.offbytwo.jenkins.helper.JenkinsVersion;
Expand All @@ -51,7 +52,10 @@
public class JenkinsServer implements Closeable {
private final Logger LOGGER = LoggerFactory.getLogger(getClass());

private final JenkinsHttpClient client;
/**
* The transport client instance to use.
*/
private final JenkinsHttpConnection client;

/**
* Create a new Jenkins server reference given only the server address
Expand Down Expand Up @@ -80,7 +84,7 @@ public JenkinsServer(URI serverUri, String username, String passwordOrToken) {
*
* @param client Specialized client to use.
*/
public JenkinsServer(JenkinsHttpClient client) {
public JenkinsServer(final JenkinsHttpConnection client) {
this.client = client;
}

Expand Down
Loading