Skip to content

Fix #118: Avoid the unsafe cast in Build#Stop() #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Fix #118: Avoid the unsafe cast in Build#Stop() #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions jenkins-client/src/main/java/com/offbytwo/jenkins/model/Build.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,13 @@ public String Stop() throws HttpResponseException, IOException {
try {

return client.get(url + "stop");
} catch (IOException ex) {
if (((HttpResponseException) ex).getStatusCode() == 405) {
} catch (HttpResponseException ex) {
if (ex.getStatusCode() == 405) {
stopPost();
return "";
}
throw ex;
}
return "";
}

/** Stops the build which is currently in progress. This version takes in
Expand All @@ -163,13 +163,13 @@ public String Stop(boolean crumbFlag) throws HttpResponseException, IOException
try {

return client.get(url + "stop");
} catch (IOException ex) {
if (((HttpResponseException) ex).getStatusCode() == 405) {
} catch (HttpResponseException ex) {
if (ex.getStatusCode() == 405) {
stopPost(crumbFlag);
return "";
}
throw ex;
}
return "";
}

private void stopPost(boolean crumbFlag) throws HttpResponseException, IOException {
Expand Down