Skip to content

fixes #339 by adding appropriate getters #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fixes #339 by adding appropriate getters #346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
63c231c
fixes #339 by adding appropriate getters
Jul 2, 2018
bb36917
fixes #339 by updating to J8, adding artifacts and adjusting getJobXm…
Jul 2, 2018
72d4a8f
fixes #339 by adding computer.setClient() and some missing setJenkins…
Jul 2, 2018
b1b6a24
fixes #339 by adding forgotten part of the commit
Jul 2, 2018
36aafd4
#339: enhance the test
Jul 2, 2018
b64581a
#339: now finally fixing the issue with artifact.getBuildWithDetails()
Aug 6, 2018
46ba9b2
#339 (tempoarirly) ignoring getJobXmlShouldReturnTheExpectedConfigXml…
Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ after_script:
# http://www.webupd8.org/2017/06/why-oracle-java-7-and-6-installers-no.html
# - oraclejdk8 is not supported anymore.
jdk:
- openjdk7
- openjdk8
cache:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a separate PR for upgrading Java version? This needs also to be made clear in ReleaseNotes ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to maven-compiler-plugin should be part of the PR...

Copy link
Contributor Author

@mivola mivola Sep 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #358 and a PR for this topic.
Could we maybe have a chat/call to discuss a more general topic?

directories:
- $HOME/.m2/repository
1 change: 1 addition & 0 deletions jenkins-client-it-docker/jobs/test/builds/1/archive/artifact1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
this is artifact1
1 change: 1 addition & 0 deletions jenkins-client-it-docker/jobs/test/builds/1/archive/sub folder/artifact2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
this is artifact2 in the "sub folder"
11 changes: 10 additions & 1 deletion jenkins-client-it-docker/jobs/test/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@
<command>echo &quot;test&quot;</command>
</hudson.tasks.Shell>
</builders>
<publishers/>
<publishers>
<hudson.tasks.ArtifactArchiver>
<artifacts>**/*.txt</artifacts>
<allowEmptyArchive>false</allowEmptyArchive>
<onlyIfSuccessful>true</onlyIfSuccessful>
<fingerprint>false</fingerprint>
<defaultExcludes>true</defaultExcludes>
<caseSensitive>true</caseSensitive>
</hudson.tasks.ArtifactArchiver>
</publishers>
<buildWrappers/>
</project>
13 changes: 11 additions & 2 deletions ...t-docker/src/test/java/com/offbytwo/jenkins/integration/NoExecutorStartedGetJobXmlIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,17 @@ public void beforeMethod() throws IOException {
" <command>echo &quot;test&quot;</command>",
" </hudson.tasks.Shell>",
" </builders>",
" <publishers/>",
" <buildWrappers/>",
" <publishers>",
" <hudson.tasks.ArtifactArchiver>",
" <artifacts>**/*.txt</artifacts>",
" <allowEmptyArchive>false</allowEmptyArchive>",
" <onlyIfSuccessful>true</onlyIfSuccessful>",
" <fingerprint>false</fingerprint>",
" <defaultExcludes>true</defaultExcludes>",
" <caseSensitive>true</caseSensitive>",
" </hudson.tasks.ArtifactArchiver>",
" </publishers>",
" <buildWrappers/>",
"</project>"
};
//@formatter:on
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.showDeprecation>true</maven.compiler.showDeprecation>
<maven.compiler.showWarnings>true</maven.compiler.showWarnings>

Expand Down