Skip to content

Fixed #421 extract duplicate code #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed #421 extract duplicate code #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions jenkins-client/src/main/java/com/offbytwo/jenkins/client/JenkinsHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,15 +357,7 @@ public String post_xml(String path, String xml_data, boolean crumbFlag) throws I
if (xml_data != null) {
request.setEntity(new StringEntity(xml_data, ContentType.create("text/xml", "utf-8")));
}
HttpResponse response = client.execute(request, localContext);
jenkinsVersion = ResponseUtils.getJenkinsVersion(response);
try {
httpResponseValidator.validateResponse(response);
return IOUtils.toString(response.getEntity().getContent());
} finally {
EntityUtils.consume(response.getEntity());
releaseConnection(request);
}
return getResponse(request);
}

/**
Expand All @@ -388,6 +380,10 @@ public String post_text(String path, String textData, ContentType contentType, b
if (textData != null) {
request.setEntity(new StringEntity(textData, contentType));
}
return getResponse(request);
}

private String getResponse(HttpPost request) throws IOException {
HttpResponse response = client.execute(request, localContext);
jenkinsVersion = ResponseUtils.getJenkinsVersion(response);
try {
Expand Down