Skip to content

[JENKINS-76295] Allow SSH build agents to connect#11310

Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite:revert-commons-io-2.21.0
Nov 19, 2025
Merged

[JENKINS-76295] Allow SSH build agents to connect#11310
MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite:revert-commons-io-2.21.0

Conversation

@MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Nov 19, 2025

[JENKINS-76295] Allow SSH build agents to connect

JENKINS-76295 reports that SSH build agents fail to connect after commons-io 2.21.0 was included from pull request:

This reverts commit ab45729.

Testing done

  • Confirmed that Jenkins 2.537 fails to start an SSH build agent on Debian 13
  • Confirmed that with this change reverted, the SSH build agent starts as expected on Debian 13
  • Confirmed that all tests pass on Fedora Linux 43 with Java 21.0.9
  • Confirmed that all tests pass on Red Hat Enterprise Linux 8.10 with Java 25.0.1
  • Confirmed that 1 test fails (once) on Ubuntu 22.04 with Java 21.0.9

No automated tests are included in this pull request because the pull request needs to be evaluated quickly so that we can create a new release. I hope to create an automated test that shows the issue, but don't want to delay the release while creating the automated test.

I plan to merge this even if the ci.jenkins.io jobs do not all pass, since I've checked it in

Proposed changelog entries

  • Allow SSH build agents to connect.

Proposed changelog category

/label major-bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mawinter69, @jglick

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

….21.0 (jenkinsci#11276)"

https://issues.jenkins.io/browse/JENKINS-76295 reports that SSH build
agents fail to connect after this change was included.

Testing done:

* Confirmed that Jenkins 2.537 fails to start an SSH build agent on
  Debian 13
* Confirmed that with this change reverted, the SSH build agent starts
  as expected on Debian 13

This reverts commit ab45729.
@MarkEWaite MarkEWaite added the major-bug For changelog: Major bug. Will be highlighted on the top of the changelog label Nov 19, 2025
@daniel-beck daniel-beck added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Nov 19, 2025
@MarkEWaite
Copy link
Contributor Author

Merging without waiting for ci.jenkins.io tests to pass. My local testing has checked enough configurations to justify the merge. The longer we wait to deliver the new release, the more users will report the issue and need our time to respond to the reports.

@MarkEWaite MarkEWaite merged commit 74ff843 into jenkinsci:master Nov 19, 2025
15 of 18 checks passed
@MarkEWaite MarkEWaite deleted the revert-commons-io-2.21.0 branch November 19, 2025 04:05
@jglick
Copy link
Member

jglick commented Nov 19, 2025

Would be interesting to bisect apache/commons-io@rel/commons-io-2.20.0...rel/commons-io-2.21.0 as the problem may be due to an upstream regression that the devs ought to be alerted to. For example apache/commons-io#779 looks like a possible culprit.

@timja
Copy link
Member

timja commented Nov 21, 2025

Would be interesting to bisect apache/commons-io@rel/commons-io-2.20.0...rel/commons-io-2.21.0 as the problem may be due to an upstream regression that the devs ought to be alerted to. For example apache/commons-io#779 looks like a possible culprit.

Tracking in #11314 FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major-bug For changelog: Major bug. Will be highlighted on the top of the changelog regression-fix Pull request that fixes a regression in one of the previous Jenkins releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments