Fix Cloud#getUrl when 2 clouds with same name exist#26177
Open
mawinter69 wants to merge 7 commits intojenkinsci:masterfrom
Open
Fix Cloud#getUrl when 2 clouds with same name exist#26177mawinter69 wants to merge 7 commits intojenkinsci:masterfrom
mawinter69 wants to merge 7 commits intojenkinsci:masterfrom
Conversation
When 2 clouds are created with the same name, then accessing the second cloud produces a different url.
mawinter69
commented
Jan 25, 2026
| <j:set var="url" value="doDelete" /> | ||
| <j:if test="${attrs.urlPrefix != null}"> | ||
| <j:set var="url" value="${urlPrefix}/doDelete" /> | ||
| <j:set var="basePrefix" value="${urlPrefix.endsWith('/') ? urlPrefix.substring(0, urlPrefix.length() - 1) : urlPrefix}" /> |
NotMyFault
approved these changes
Jan 29, 2026
Contributor
Author
|
This is obsolete when #26233 is merged. Using the Ids is the more reliable way and fixes all the problems around duplicate names, |
14 tasks
Contributor
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in #26004 was not sufficient when 2 clouds are created with the same name.
The second cloud produces a different url but in
t:actionsthe url for the action is computed fromit.urlwhich used the non indexed url so basically going to the wrong cloud.Similarly when saving such a cloud the form was redirecting to the wrong url
Fixes #26174
Fixes #26183
Testing done
Adjusted the tests in
CloudTest:Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.