Fix 404 after deleting an indexed cloud#26181
Open
mawinter69 wants to merge 1 commit intojenkinsci:masterfrom
Open
Fix 404 after deleting an indexed cloud#26181mawinter69 wants to merge 1 commit intojenkinsci:masterfrom
mawinter69 wants to merge 1 commit intojenkinsci:masterfrom
Conversation
When 2 clouds have the same name the second one has a different url with `cloudByIndex` as additional intermediate. When deleting the cloud it redirected to `..` i.e. `/cloud/cloudByIndex/` which produces a 404. Deleting a cloud now redirects to `/cloud`
NotMyFault
approved these changes
Jan 29, 2026
Member
NotMyFault
left a comment
There was a problem hiding this comment.
Untested, but changeset looks plausible.
NotMyFault
approved these changes
Jan 29, 2026
Member
NotMyFault
left a comment
There was a problem hiding this comment.
Untested, but changeset looks plausible.
Contributor
Author
|
That is also obsolete with #26233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 2 clouds have the same name the second one has a different url with
cloudByIndexas additional path element. When deleting the cloud it redirects to.., i.e./cloud/cloudByIndex/which produces a 404.Deleting a cloud now redirects to
/cloudFixes #26176
Testing done
googlein the clouds name fieldDelete CloudScreenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.