Skip to content

Fix 404 after deleting an indexed cloud#26181

Open
mawinter69 wants to merge 1 commit intojenkinsci:masterfrom
mawinter69:issue-26716
Open

Fix 404 after deleting an indexed cloud#26181
mawinter69 wants to merge 1 commit intojenkinsci:masterfrom
mawinter69:issue-26716

Conversation

@mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jan 25, 2026

When 2 clouds have the same name the second one has a different url with cloudByIndex as additional path element. When deleting the cloud it redirects to .., i.e. /cloud/cloudByIndex/ which produces a 404.
Deleting a cloud now redirects to /cloud

Fixes #26176

Testing done

  1. Installed google-compute-engine plugin
  2. created 2 clouds that both use google in the clouds name field
  3. visit the second cloud and clicked Delete Cloud
  4. This does no longer throw a 404

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Fix 404 after deleting an indexed cloud

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

When 2 clouds have the same name the second one has a different url with
`cloudByIndex` as additional intermediate. When deleting the cloud it
redirected to `..` i.e. `/cloud/cloudByIndex/` which produces a 404.
Deleting a cloud now redirects to `/cloud`
@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Jan 25, 2026
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but changeset looks plausible.

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but changeset looks plausible.

@mawinter69
Copy link
Contributor Author

That is also obsolete with #26233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting a cloud that has cloudByIndex in the url leads to a 404

2 participants