Add lang attribute to HTML pages#26340
Add lang attribute to HTML pages#26340somiljain2006 wants to merge 4 commits intojenkinsci:masterfrom
Conversation
MarkEWaite
left a comment
There was a problem hiding this comment.
I think this needs more discussion in the user experience SIG before any implementation. I'd want to hear from people with more experience with accessibility before implementing a change from a single issue report from a first time reporter. The issue report has no additional comments or any hints that there is a real benefit to the user by complying with their company usability guidelines.
|
If I navigate to https://weekly.ci.jenkins.io/ using the Accept-Language I doubt it's better to provide an incorrect programmatic declaration of language, than none at all. |
|
The request2.getLocale() reflects the requested locale, but not necessarily the language Jenkins renders the UI in, so is there an existing API in Jenkins core or Stapler that exposes the resolved UI language for a page, rather than just the requested locale? |
There is no such thing as a "resolved locale". Each individual resource is served in the requested language, or fallback (English). Basically all languages have incomplete translations, so parts of the page are English, others in the requested language. |
|
FTR this also doesn't address the requested enhancement as it doesn't add
|
Add a lang attribute to the root element for Jenkins UI pages so the default document language is programmatically determinable.
Fixes #16649
Testing done
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Add a
langattribute to Jenkins HTML pages.Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/core-pr-reviewers
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.