Skip to content

[JENKINS-76289] Add icon size control to new dashboard page#26345

Open
Flamki wants to merge 1 commit intojenkinsci:masterfrom
Flamki:fix-dashboard-icon-size-76289
Open

[JENKINS-76289] Add icon size control to new dashboard page#26345
Flamki wants to merge 1 commit intojenkinsci:masterfrom
Flamki:fix-dashboard-icon-size-76289

Conversation

@Flamki
Copy link
Contributor

@Flamki Flamki commented Feb 21, 2026

Fixes #16844

Testing done

  • Added regression test newDashboardShowsIconSizeControl in ViewTest.
  • The test enables new-dashboard-page.flag for a user and verifies the new dashboard still renders icon-size controls.
  • Executed locally:
    • mvn -am -pl war,bom -Pquick-build -DskipTests clean install
    • mvn -pl test -Dtest=hudson.model.ViewTest#newDashboardShowsIconSizeControl test
  • Result: Tests run: 1, Failures: 0, Errors: 0, Skipped: 0.

Screenshots (UI changes only)

Before
N/A

After
N/A

Proposed changelog entries

Add icon size controls to the new dashboard page.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate. (No new public API in this PR.)
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable. (No new deprecations in this PR.)
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation). (No new JS/UI behavior pattern; only Jelly composition change.)
  • For dependency updates, there are links to external changelogs and, if possible, full differentials. (No dependency updates in this PR.)
  • For new APIs and extension points, there is a link to at least one consumer. (No new API/extension point in this PR.)

Desired reviewers

@jenkinsci/core-pr-reviewers

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Feb 21, 2026
@mawinter69
Copy link
Contributor

please provide screenshots

@Flamki
Copy link
Contributor Author

Flamki commented Feb 21, 2026

please provide screenshots

Thanks for the review. Added screenshots.

Before (master, new dashboard):

  • Icon size control is missing.
Screenshot 2026-02-22 024115

After (this PR #26345):

  • Icon size control (S / M / L) is available on the new dashboard.
Screenshot 2026-02-22 024140 Screenshot 2026-02-22 024131 Screenshot 2026-02-22 024123

@Flamki Flamki force-pushed the fix-dashboard-icon-size-76289 branch from a245d08 to 97f2599 Compare March 2, 2026 17:04
@Flamki
Copy link
Contributor Author

Flamki commented Mar 3, 2026

Rebased on latest master; no functional changes, only branch update for merge readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JENKINS-76289] New dashboard page: Missing icon size control

2 participants