[JENKINS-76289] Add icon size control to new dashboard page#26345
Open
Flamki wants to merge 1 commit intojenkinsci:masterfrom
Open
[JENKINS-76289] Add icon size control to new dashboard page#26345Flamki wants to merge 1 commit intojenkinsci:masterfrom
Flamki wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Contributor
|
please provide screenshots |
Contributor
Author
Thanks for the review. Added screenshots. Before (master, new dashboard):
After (this PR #26345):
|
a245d08 to
97f2599
Compare
Contributor
Author
|
Rebased on latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #16844
Testing done
newDashboardShowsIconSizeControlinViewTest.new-dashboard-page.flagfor a user and verifies the new dashboard still renders icon-size controls.mvn -am -pl war,bom -Pquick-build -DskipTests clean installmvn -pl test -Dtest=hudson.model.ViewTest#newDashboardShowsIconSizeControl testTests run: 1, Failures: 0, Errors: 0, Skipped: 0.Screenshots (UI changes only)
Before
N/A
After
N/A
Proposed changelog entries
Add icon size controls to the new dashboard page.
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate. (No new public API in this PR.)@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable. (No new deprecations in this PR.)evalto ease future introduction of Content Security Policy (CSP) directives (see documentation). (No new JS/UI behavior pattern; only Jelly composition change.)Desired reviewers
@jenkinsci/core-pr-reviewers
Before the changes are marked as ready-for-merge:
Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.