Add getComment() to ChangeLogSet.Entry#26347
Add getComment() to ChangeLogSet.Entry#263470xShubhamSolanki wants to merge 1 commit intojenkinsci:masterfrom
Conversation
|
I've converted the pull request to draft because you've made several mistakes that need to be corrected before anyone reviews the pull requests. Those mistakes include:
If those steps are not taken promptly, I'll close the pull request as wasting maintainer time. In the future, pull requests like this will one will be immediately closed. |
MarkEWaite
left a comment
There was a problem hiding this comment.
Requesting changes based on my previous comment
|
Thank you for the detailed feedback. |
781e013 to
05e4925
Compare
05e4925 to
16a86d5
Compare
|
@MarkEWaite |
Thanks. I will be on vacation for the next two weeks, so won't be reviewing pull requests in any significant way. I'll review this after I return from vacation. |
Fixes #22542
Adds a new
getComment()method toChangeLogSet.Entryto expose the full commit message.Currently, only
getMsg()is available, which typically returns the short commit message.Some integrations and API consumers require access to the full commit message.
The default implementation of
getComment()returnsgetMsg()to preserve backward compatibility and existing behavior.SCM implementations may override this method if they provide a distinct full commit message.
Testing done
Built Jenkins core locally with JDK 21.
mvn -pl core clean verify
Added automated unit test
ChangeLogSetEntryTestwhich verifies:getComment()returns the same value asgetMsg()by default.getComment()can be overridden by concrete SCM implementations.The test includes a concrete anonymous subclass of
ChangeLogSet.Entryto simulate real SCM implementations overriding the method.Confirmed that:
getMsgAnnotated()continues to work as expected.Screenshots (UI changes only)
Before
N/A
After
N/A
Proposed changelog entries
getComment()inChangeLogSet.Entry.Proposed changelog category
/label developer
Proposed upgrade guidelines
N/A
Submitter checklist
@Exportedand@since 2.552.Desired reviewers
@MarkEWaite