Redesigned new job page: CascadeChoiceParameter does not work#26416
Open
Eyepatch5263 wants to merge 5 commits intojenkinsci:masterfrom
Open
Redesigned new job page: CascadeChoiceParameter does not work#26416Eyepatch5263 wants to merge 5 commits intojenkinsci:masterfrom
Eyepatch5263 wants to merge 5 commits intojenkinsci:masterfrom
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
Contributor
|
This is a bit hacky I think and might have undesired sideeffects by resending the |
Author
|
Okay, I'll try modifying the active choice plugin. |
daniel-beck
reviewed
Mar 6, 2026
| ); | ||
| content.appendChild(this.options.content); | ||
| this.dialog.appendChild(content); | ||
| _reapplyBehaviors(content); |
Member
There was a problem hiding this comment.
Wouldn't at least a call to #applySubtree still be needed here even if the plugin uses Behavior?
Author
There was a problem hiding this comment.
Yes, it will be needed, we will need to create one more issue in active-choice-plugin
… instead of DOMConrentLoaded dispatch from jenkins core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26371
Testing done
Enabled the experimental feature, new job page and built a job with the provided groovy code and reviewed the build with parameter UI.
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.