Skip to content

Redesigned new job page: CascadeChoiceParameter does not work#26416

Open
Eyepatch5263 wants to merge 5 commits intojenkinsci:masterfrom
Eyepatch5263:fixes/cascadeError
Open

Redesigned new job page: CascadeChoiceParameter does not work#26416
Eyepatch5263 wants to merge 5 commits intojenkinsci:masterfrom
Eyepatch5263:fixes/cascadeError

Conversation

@Eyepatch5263
Copy link

@Eyepatch5263 Eyepatch5263 commented Mar 5, 2026

Fixes #26371

Testing done

Enabled the experimental feature, new job page and built a job with the provided groovy code and reviewed the build with parameter UI.

Screenshots (UI changes only)

Before

Screenshot From 2026-03-05 23-37-58

After

image

Proposed changelog entries

  • Added _reapplyBehaviors() function that dispatches DOMContentLoaded on both document and window after dialog content is appended to the DOM. This allows plugins like Active Choices, which register DOMContentLoaded listeners during script loading, to initialize correctly when dialog content is loaded dynamically via rednerOnDemand

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@welcome
Copy link

welcome bot commented Mar 5, 2026

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Mar 5, 2026
@Eyepatch5263 Eyepatch5263 changed the title Fixes/cascade error Redesigned new job page: CascadeChoiceParameter does not work Mar 5, 2026
@mawinter69
Copy link
Contributor

This is a bit hacky I think and might have undesired sideeffects by resending the DOMContentLoaded event. It would be better to change the active choice plugin to use Behavior

@Eyepatch5263
Copy link
Author

Okay, I'll try modifying the active choice plugin.

);
content.appendChild(this.options.content);
this.dialog.appendChild(content);
_reapplyBehaviors(content);
Copy link
Member

@daniel-beck daniel-beck Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't at least a call to #applySubtree still be needed here even if the plugin uses Behavior?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will be needed, we will need to create one more issue in active-choice-plugin

@Eyepatch5263 Eyepatch5263 reopened this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesigned new job page: CascadeChoiceParameter does not work

3 participants