Refine how administrative monitors are displayed#26417
Draft
mawinter69 wants to merge 2 commits intojenkinsci:masterfrom
Draft
Refine how administrative monitors are displayed#26417mawinter69 wants to merge 2 commits intojenkinsci:masterfrom
mawinter69 wants to merge 2 commits intojenkinsci:masterfrom
Conversation
Member
|
cc @janfaracik thoughts? Thanks for doing this! Generally looks great. My only concern is around the different button sizes on the same row. Could be handled by making them all the same size? Possibly using the same approach with an icon that changes to text on hover? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Introduce a
l:adminMonitortag lib to unify how administrative monitors are shown to the user. By default admin monitors are shown with severity warning and get a small close button in the top right. This button will expand to a given value when hovering. When clicked the existingdoDisablemethod is called via javascript to dismiss (disable) the monitor and on success the corresponding monitor is removed from the DOM. This avoids that a reload of the page has to be done.This change also adjusts how many monitors act when clicking buttons. Frequently they implemented a
doActmethod, that depending on parameters (clicking form buttons usually) either dismissed the monitor or forwarded to another url. Buttons that did nothing but forwarding to another url now directly render anaelement with the url avoiding the call to thedoActmethod.This changes all admin monitors in Jenkins core. Monitors in plugins will need to adopt to the new taglib.
Fixes #18321
Testing done
Screenshots (UI changes only)
tbd
Before
After
Screenshots
Old Manage page:New manage page:

Video:
https://github.com/user-attachments/assets/424d0d39-dc04-459f-885f-568b0f815b03
Proposed changelog entries
Proposed changelog category
/label rfe,web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.