Make https default for plugin downloads#265
Conversation
|
The mirrors still do not support https so I am unsure if it does not find would it default to http |
|
I guess we still need to wait until HTTPS is ok. |
|
Yes, I suggest putting it on hold until the new Mirror infra is rolled out. CC @olblak |
|
@oleg-nenashev / @sladyn98 I think this can be rebased and |
|
Agreed @rsvoboda |
oleg-nenashev
added
enhancement
|
It worth mentioning that this code will be removed once Plugin Installation Manager Tool is integrated in #324. I am not a big fan of using on-demand plugin download even with that tool, in the most of cases it is better package plugins in the Build Time while packaging custom JFR images. Good for some demos though |
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Works on my machine (c). I added test coverage in #391 , but this is not a right time to spend too much time on tests for this feature. Tests will be a must when integrating Plugin Installation Manager
5 participants
This PR aims to make https default for downloading plugins.
Closes: #258